Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: handle corrupted length in uncompress builtin function #8607

Merged
merged 1 commit into from
Dec 7, 2018
Merged

expression: handle corrupted length in uncompress builtin function #8607

merged 1 commit into from
Dec 7, 2018

Conversation

ziyi-yan
Copy link
Contributor

@ziyi-yan ziyi-yan commented Dec 6, 2018 •
edited by c4pt0r
Loading

What problem does this PR solve?

fixes #8578 on release-2.0

What is changed and how it works?

cherry-pick a bug fix commit(e61bad0) from this PR.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

This change is Reviewable

@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@ziyi-yan
Copy link
Contributor Author

ziyi-yan commented Dec 6, 2018

@zz-jason PTAL

jackysp
jackysp reviewed Dec 7, 2018
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Dec 7, 2018

/run-all-tests tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

zz-jason
zz-jason approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. component/expression labels Dec 7, 2018
@zz-jason
Copy link
Member

zz-jason commented Dec 7, 2018

/run-integration-ddl-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

1 similar comment
@zz-jason
Copy link
Member

zz-jason commented Dec 7, 2018

/run-integration-ddl-test tidb-test=release-2.0 tikv=release-2.0 pd=release-2.0

@zz-jason zz-jason merged commit fe00792 into pingcap:release-2.0 Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ziyi-yan @sre-bot @jackysp @zz-jason @morgo