Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, planner: refine merge join compare methods to avoid some rare cases #9390

Merged
merged 6 commits into from
Feb 25, 2019

Conversation

zz-jason
Copy link
Member

What problem does this PR solve?

fix merge join incorrect result in some rare cases.

What is changed and how it works?

change the compare method

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

@zz-jason zz-jason added type/bugfix This PR fixes a bug. sig/planner SIG: Planner sig/execution SIG execution labels Feb 21, 2019
@zz-jason
Copy link
Member Author

/run-all-tests

@codecov-io
Copy link

codecov-io commented Feb 21, 2019

Codecov Report

Merging #9390 into master will increase coverage by <.01%.
The diff coverage is 73.17%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9390      +/-   ##
==========================================
+ Coverage   67.19%   67.19%   +<.01%     
==========================================
  Files         373      373              
  Lines       78331    78386      +55     
==========================================
+ Hits        52634    52671      +37     
- Misses      20985    20995      +10     
- Partials     4712     4720       +8
Impacted Files Coverage Δ
planner/core/physical_plans.go 60.86% <ø> (ø) ⬆️
executor/builder.go 83.69% <100%> (+0.08%) ⬆️
planner/core/exhaust_physical_plans.go 92.4% <57.14%> (-1.69%) ⬇️
expression/builtin_compare.go 73.07% <74.54%> (-0.84%) ⬇️
executor/merge_join.go 79.45% <75%> (-1.01%) ⬇️
executor/distsql.go 72.24% <0%> (+0.45%) ⬆️
executor/join.go 79.42% <0%> (+0.52%) ⬆️
expression/schema.go 94.53% <0%> (+0.78%) ⬆️
ddl/delete_range.go 77.77% <0%> (+2.64%) ⬆️
store/tikv/scan.go 77.31% <0%> (+3.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266ff4b...d8d2fcc. Read the comment docs.

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 25, 2019
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 2f3842a into pingcap:master Feb 25, 2019
@zz-jason zz-jason deleted the bugfix/mergejoin-compare-funcs branch February 25, 2019 06:19
zz-jason added a commit to zz-jason/tidb that referenced this pull request Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants