-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, planner: refine merge join compare methods to avoid some rare cases #9390
executor, planner: refine merge join compare methods to avoid some rare cases #9390
Conversation
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #9390 +/- ##
==========================================
+ Coverage 67.19% 67.19% +<.01%
==========================================
Files 373 373
Lines 78331 78386 +55
==========================================
+ Hits 52634 52671 +37
- Misses 20985 20995 +10
- Partials 4712 4720 +8
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
fix merge join incorrect result in some rare cases.
What is changed and how it works?
change the compare method
Check List
Tests
Code changes
Related changes