Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor, planner: refine merge join compare methods to avoid some rare cases (#9390) #9438

Merged

Conversation

zz-jason
Copy link
Member

cherry pick #9390 to release 2.1

@zz-jason
Copy link
Member Author

/run-all-tests

@zz-jason
Copy link
Member Author

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason requested review from XuHuaiyu and winoros and removed request for XuHuaiyu February 25, 2019 07:01
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zz-jason zz-jason merged commit 693c9ed into pingcap:release-2.1 Feb 25, 2019
@zz-jason zz-jason deleted the cherrypick/2.1-mergejoin-compare-funcs branch February 25, 2019 07:15
@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. status/all tests passed type/bugfix This PR fixes a bug. labels Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants