store/tikv: add sanity check for startTS in 2pc #9555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <[email protected]>
|
Related to #9283 |
|
@disksing Please fix the CI. |
Signed-off-by: disksing <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9555 +/- ##
==========================================
- Coverage 67.37% 67.36% -0.02%
==========================================
Files 375 375
Lines 78779 78783 +4
==========================================
- Hits 53081 53075 -6
- Misses 20927 20935 +8
- Partials 4771 4773 +2
Continue to review full report at Codecov.
|
|
LGTM |
|
/run-all-tests |
shenli
approved these changes
Mar 5, 2019
disksing
added
status/all tests passed
status/LGT3
This was referenced Mar 5, 2019
jackysp
pushed a commit
that referenced
this pull request
Mar 5, 2019
jackysp
pushed a commit
that referenced
this pull request
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: disksing [email protected]
What problem does this PR solve?
To avoid committing a transaction with MAX_UINT64 unexpectedly.
What is changed and how it works?
Sometimes (PointGet, Analyze) TiDB uses special startTS (MAX_UINT64) to initialize a transaction. This is dangerous because
txn.Commit()may be called unexpectedly.Check List
Tests
Related changes