Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store/tikv: add sanity check for startTS in 2pc (#9555) #9558

Merged
merged 1 commit into from
Mar 5, 2019
Merged

store/tikv: add sanity check for startTS in 2pc (#9555) #9558

merged 1 commit into from
Mar 5, 2019

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Mar 5, 2019

Signed-off-by: disksing [email protected]

What problem does this PR solve?

To avoid committing a transaction with MAX_UINT64 unexpectedly.
Sometimes (PointGet, Analyze) TiDB uses special startTS (MAX_UINT64) to initialize a transaction. This is dangerous because txn.Commit() may be called unexpectedly.

What is changed and how it works?

cherry-pick #9555

Check List

Tests

  • Unit test

* store/tikv: add sanity check for startTS in 2pc

Signed-off-by: disksing <[email protected]>
@shenli
Copy link
Member

shenli commented Mar 5, 2019

LGTM

@shenli shenli added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 5, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 5, 2019

/run-all-tests tidb-test=release-2.0 tidb-private-test=release-2.0 tikv=release-2.0

@jackysp jackysp merged commit f15460a into pingcap:release-2.0 Mar 5, 2019
@disksing disksing deleted the cherry-pick-9555-1 branch May 20, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants