Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interpreter planner refactor #4739

Closed
13 tasks done
SeaRise opened this issue Apr 24, 2022 · 1 comment · Fixed by #5426 or #5493
Closed
13 tasks done

interpreter planner refactor #4739

SeaRise opened this issue Apr 24, 2022 · 1 comment · Fixed by #5426 or #5493
Assignees
@SeaRise
Labels
component/compute component/mpp type/code-quality-improvement PR that can improve the code quality type/enhancement The issue or PR belongs to an enhancement.

Comments

@SeaRise
Copy link
Contributor

SeaRise commented Apr 24, 2022 •
edited
Loading

Enhancement

background

Currently tiflash's interpreter is designed based on DAGQueryBlock.
DAGQueryBlock is designed to coprocess read, and it can handle simple queries well.
However, there is no way to handle the complex query of MPP, so the DAGQueryBlock tree is introduced, which is a compromise that makes the code more complicated and affects the subsequent iterative development.
We need to refactor the interpreter code in a plan visit way.

design

Therefore we introduce a new abstraction layer called PhysicalPlan to replace DAGQueryBlock.
It will be responsible for the processing of ExpressionAction and the generation of BlockInputStream.
We call this organization of code the planner.

DAGRequest (executor tree or executor array).
     |
     |
     v
physical plan <---+
     |            |
     |            | optimize
     |            |
     +------------+   
     |
     |
     v
BlockInputStream

why planner

Most databases are designed based on planner.

  • Friendly for database developers to understand code.
  • We can improve tiflash with a general approach from the DB area, such as pipeline mode.

todo list
@SeaRise SeaRise added the type/enhancement The issue or PR belongs to an enhancement. label Apr 24, 2022
@SeaRise SeaRise self-assigned this Apr 24, 2022
@SeaRise SeaRise changed the title interpreter planner refactory interpreter planner refactor Apr 24, 2022
@SeaRise SeaRise mentioned this issue Apr 24, 2022
Merged
12 tasks
@SeaRise SeaRise mentioned this issue May 5, 2022
Merged
12 tasks
@SeaRise SeaRise mentioned this issue May 31, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jun 8, 2022
@SeaRise
Feature Branch: merge master to planner_refactory branch (#5034)
44c4400 
ref #4739
ti-chi-bot pushed a commit that referenced this issue Jun 13, 2022
@SeaRise
Introduce physical plan and add switch (#4820)
aabe213 
ref #4739
@SeaRise SeaRise mentioned this issue Jun 20, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jul 8, 2022
@SeaRise
Planner: Support common physical plans (#5143)
07b1b20 
ref #4739
This was referenced Jul 8, 2022
Merged
Merged
Closed
Merged
Merged
ti-chi-bot pushed a commit that referenced this issue Jul 11, 2022
@SeaRise
*: mini refactor (#5326)
4619605 
close #4739
@SeaRise SeaRise reopened this Jul 11, 2022
@SeaRise SeaRise mentioned this issue Jul 12, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jul 12, 2022
@SeaRise
Feature Branch: merge master to planner_refactory branch (#5353)
05fd9bd 
ref #4739
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this issue Jul 12, 2022
@hongyunyan @Lloyd-Pottiger
Enhancement: Add how to run integration tests and microbenchmark test…
4e4f3b7 
…s in README (pingcap#5182)

close pingcap#5172, ref pingcap#5178

Enhancement: add a integrated test on DDL module (pingcap#5130)

ref pingcap#5129

Revert "Revise default background threads size" (pingcap#5176)

close pingcap#5177

chore: remove extra dyn cast (pingcap#5186)

close pingcap#5185

Add MPPReceiverSet, which includes ExchangeReceiver and CoprocessorReader (pingcap#5175)

ref pingcap#5095

DDL: Use Column Name Instead of Offset to Find the common handle cluster index (pingcap#5166)

close pingcap#5154

Add random failpoint in critical paths (pingcap#4876)

close pingcap#4807

Segment test framework (pingcap#5150)

close pingcap#5151

optimize ps v3 restore (pingcap#5163)

ref pingcap#4914

Fix build failed (pingcap#5196)

close pingcap#5195

feat: delta tree dispatching (pingcap#5199)

close pingcap#5200

feat: introduce specialized API to write fixed length data rapidly (pingcap#5181)

close pingcap#5183

Add gtest for Limit, TopN, Projection (pingcap#5187) (pingcap#5188)

close pingcap#5187

add `MPPTask::handleError()` (pingcap#5202)

ref pingcap#5095

Check result of starting grpc server (pingcap#5257)

close pingcap#5255

feat: add optimized routines for aarch64 (pingcap#5231)

close pingcap#5240

fix: aarch64-quick-fix (pingcap#5259)

close pingcap#5260

Update client-c to support ipv6 (pingcap#5270)

close pingcap#5247

upgrade prometheus-cpp to v1.0.1 (pingcap#5279)

ref pingcap#2103, close pingcap#5278

Fix README type error (pingcap#5273)

ref pingcap#5178

fix(cmake): make sure libc++ is utilized by tiflash-proxy (pingcap#5281)

close pingcap#5282

fix the wrong order of execution summary for list based executors (pingcap#5242)

close pingcap#5241

Schema: allow loading empty schema diff when the version grows up. (pingcap#5245)

close pingcap#5244

Optimize apply speed under heavy write pressure (pingcap#4883)

ref pingcap#4728

update proxy to raftstore-proxy-6.2 (pingcap#5287)

ref pingcap#4982

Flush segment cache when doing the compaction (pingcap#5284)

close pingcap#5179

metrics: Fix incorrect metrics for delta_merge tasks (pingcap#5061)

close pingcap#5055

dep: upgrade jemalloc (pingcap#5197)

close pingcap#5258

*: TiFlash pagectl/dttool use only-decryption mode (pingcap#5271)

close pingcap#5122

suppresion false positive report from tsan (pingcap#5303)

close pingcap#5088

Refine test framework code and tests (pingcap#5261)

close pingcap#5262

feat: add logical cpu cores and memory into grafana (pingcap#5124)

close pingcap#3821

Implement TimeToSec function push down (pingcap#5235)

close pingcap#5116

feat: implement shiftRight function push down (pingcap#5156)

close pingcap#5100

schema : make update to partition tables when 'set tiflash replica' (pingcap#5267)

close pingcap#5266

Replace initializer_list with vector for planner test framework (pingcap#5307)

close pingcap#5295

KVStore: decouple flush region and CompactLog with a new FFI fn_try_flush_data (pingcap#5283)

ref pingcap#5170

refine error message in mpptask (pingcap#5304)

ref pingcap#5095

Implement ReverseUTF8/Reverse function push down (pingcap#5233)

close pingcap#5111

Optimize comparision for collation `UTF8_BIN` and `UTF8MB4_BIN` (pingcap#5299)

ref pingcap#5294

feat : support set tiflash mode ddl action (pingcap#5256)

ref pingcap#5252

Add non-blocking functions for MPMCQueue (pingcap#5311)

close pingcap#5310

add random segment test for CI weekly (pingcap#5300)

close pingcap#5301

*: tidy FunctionString.cpp (pingcap#5312)

close pingcap#5313

ci: fix check-license github action (pingcap#5318)

close pingcap#5317

update proxy to raftstore-proxy-6.2 (pingcap#5316)

ref pingcap#4982

Change one `additional_input_at_end` to many streams in `ParallelInputsProcessor`  (pingcap#5274)

close pingcap#4856, close pingcap#5263

support fine grained shuffle for window function (pingcap#5048)

close pingcap#5142

feat: pushdown get_format into TiFlash (pingcap#5269)

close pingcap#5115

fix: format throw data truncated error (pingcap#5272)

close pingcap#4891

Print content of columns for gtest (pingcap#5243)

close pingcap#5203

*: also enable O3 for aarch64 (pingcap#5338)

close pingcap#5342

Add debug image build target for CentOS7 (pingcap#5344)

close pingcap#5343

*: mini refactor (pingcap#5326)

close pingcap#4739

Refactor initialize of background pool (pingcap#5190)

close pingcap#5189

delete copy/move ctor of MPMCQueue explicitly (pingcap#5328)

close pingcap#5329

Introduce proxy_server and new-mock-engine-store (pingcap#5319)

ref pingcap#5170

fix: incorrect uptime in grafana panel

Signed-off-by: Lloyd-Pottiger <[email protected]>
This was referenced Jul 13, 2022
Merged
Merged
SeaRise added a commit to SeaRise/tiflash that referenced this issue Jul 18, 2022
@SeaRise
merge master to feature branch: , ref pingcap#4739
767e891
SeaRise added a commit to SeaRise/tiflash that referenced this issue Jul 18, 2022
@SeaRise
merge master to Feature branch: planner_refactory ref pingcap#4739
c5fd86b
SeaRise added a commit to SeaRise/tiflash that referenced this issue Jul 18, 2022
@SeaRise
merge master to Feature branch: planner_refactory ref pingcap#4739
6a0c56b
SeaRise added a commit to SeaRise/tiflash that referenced this issue Jul 18, 2022
@SeaRise
merge master to Feature branch: planner_refactory ref pingcap#4739
7693e14
Lloyd-Pottiger pushed a commit to Lloyd-Pottiger/tiflash that referenced this issue Jul 19, 2022
@SeaRise @Lloyd-Pottiger
*: mini refactor (pingcap#5326)
6061525 
close pingcap#4739
@SeaRise SeaRise mentioned this issue Jul 20, 2022
Merged
12 tasks
ti-chi-bot added a commit that referenced this issue Jul 25, 2022
@ti-chi-bot
Feature Branch: merge master to planner_refactory (#5426)
aa20f61 
ref #4739
ti-chi-bot pushed a commit that referenced this issue Jul 25, 2022
@SeaRise
Planner: support table scan (#5335)
42b4055 
ref #4739
ti-chi-bot pushed a commit that referenced this issue Jul 25, 2022
@SeaRise
Planner: support Join (#5320)
a528f48 
ref #4739
@SeaRise SeaRise mentioned this issue Jul 25, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jul 26, 2022
@SeaRise
Planner: support window (#5363)
d9bcbde 
ref #4739
ti-chi-bot pushed a commit that referenced this issue Jul 26, 2022
@SeaRise
refine InterpreterDAG (#5466)
a476307 
ref #4739
@SeaRise SeaRise mentioned this issue Jul 28, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Aug 2, 2022
@SeaRise
Planner: planner without DAGQueryBlock (#5381)
0f26fe8 
ref #4739
@SeaRise SeaRise mentioned this issue Aug 2, 2022
Merged
ti-chi-bot added a commit that referenced this issue Aug 3, 2022
@ti-chi-bot
Feature Branch: merge master to planner_refactory (#5493)
67a084c 
close #4739
ti-chi-bot pushed a commit that referenced this issue Aug 10, 2022
@SeaRise
Planner: Support Planner Interpreter (#5321)
f470b46 
ref #4739
ti-chi-bot pushed a commit that referenced this issue Sep 1, 2022
@SeaRise
doc: planner refactor (#4743)
b4ddec8 
ref #4739
@SeaRise
Copy link
Contributor Author

SeaRise commented Sep 1, 2022

all merged.

@SeaRise SeaRise closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeaRise SeaRise

Labels
component/compute component/mpp type/code-quality-improvement PR that can improve the code quality type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
1 participant
@SeaRise