Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test of CreateTables using affected opts #4239

Merged
merged 5 commits into from
Mar 14, 2022

Conversation

CalvinNeo
Copy link
Member

@CalvinNeo CalvinNeo commented Mar 14, 2022

What problem does this PR solve?

Issue Number: close #4235

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: CalvinNeo <[email protected]>
f
Signed-off-by: CalvinNeo <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JaySon-Huang
  • jiaqizho

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 14, 2022
Signed-off-by: CalvinNeo <[email protected]>
@SchrodingerZhu
Copy link
Contributor

/rebuild

1 similar comment
@CalvinNeo
Copy link
Member Author

/rebuild

@CalvinNeo
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 14, 2022
@CalvinNeo
Copy link
Member Author

/cc @jiaqizho

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 14, 2022
@CalvinNeo
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

@CalvinNeo: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ab83814

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 14, 2022
@sre-bot
Copy link
Collaborator

sre-bot commented Mar 14, 2022

Coverage for changed files

Filename                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/MockTiDB.cpp                             149               145     2.68%          34                32     5.88%         450               432     4.00%          98                97     1.02%
Flash/Mpp/MPPTunnel.h                            8                 8     0.00%           8                 8     0.00%          14                14     0.00%           0                 0         -
Interpreters/Settings.h                          1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/Transaction/SchemaBuilder.cpp         835               794     4.91%          46                42     8.70%        1030               958     6.99%         488               468     4.10%
Storages/Transaction/SchemaGetter.h              1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          994               948     4.63%          90                83     7.78%        1496              1405     6.08%         586               565     3.58%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16853      9456             43.89%    189607  95860        49.44%

full coverage report (for internal network access only)

@ti-chi-bot
Copy link
Member

@CalvinNeo: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Mar 14, 2022

Coverage for changed files

Filename                                            Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Debug/MockTiDB.cpp                                      149               145     2.68%          34                32     5.88%         450               432     4.00%          98                97     1.02%
Flash/Mpp/MPPTunnel.h                                     8                 8     0.00%           8                 8     0.00%          14                14     0.00%           0                 0         -
Interpreters/Settings.h                                   1                 0   100.00%           1                 0   100.00%           1                 0   100.00%           0                 0         -
Storages/Page/V3/PageDirectory.cpp                      441                68    84.58%          30                 3    90.00%         986               195    80.22%         364                84    76.92%
Storages/Page/V3/PageDirectory.h                         24                 6    75.00%          24                 6    75.00%         101                21    79.21%           0                 0         -
Storages/Page/V3/PageDirectoryFactory.cpp                36                 8    77.78%           4                 0   100.00%         105                20    80.95%          42                 9    78.57%
Storages/Page/V3/PageEntriesEdit.h                       54                10    81.48%          39                 8    79.49%         157                42    73.25%          14                 6    57.14%
Storages/Page/V3/WAL/WALReader.cpp                       71                 9    87.32%           9                 0   100.00%         173                13    92.49%          54                12    77.78%
Storages/Page/V3/WAL/serialize.cpp                       47                11    76.60%          15                 1    93.33%         190                41    78.42%          52                16    69.23%
Storages/Page/V3/WALStore.cpp                            69                39    43.48%           8                 1    87.50%         119                42    64.71%          32                19    40.62%
Storages/Page/V3/tests/entries_helper.h                  65                36    44.62%          10                 3    70.00%         238               111    53.36%          32                21    34.38%
Storages/Page/V3/tests/gtest_page_directory.cpp        8494              1499    82.35%          46                 0   100.00%        1549                 7    99.55%        2672              1352    49.40%
Storages/Page/V3/tests/gtest_page_storage.cpp          2599               952    63.37%          31                 7    77.42%         704               154    78.12%         832               498    40.14%
Storages/Page/V3/tests/gtest_wal_store.cpp             1941               260    86.60%          11                 0   100.00%         451                13    97.12%         642               314    51.09%
Storages/Transaction/SchemaBuilder.cpp                  835               794     4.91%          46                42     8.70%        1030               958     6.99%         488               468     4.10%
Storages/Transaction/SchemaGetter.h                       1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                 14835              3846    74.07%         317               112    64.67%        6269              2064    67.08%        5322              2896    45.58%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16861      9457             43.91%    189868  95834        49.53%

full coverage report (for internal network access only)

@ti-chi-bot ti-chi-bot merged commit 18b4b04 into pingcap:master Mar 14, 2022
ywqzzy pushed a commit to ywqzzy/tiflash_1 that referenced this pull request Mar 14, 2022
ywqzzy added a commit to ywqzzy/tiflash_1 that referenced this pull request Mar 14, 2022
Signed-off-by: ywqzzy <[email protected]>

update.

Signed-off-by: ywqzzy <[email protected]>

update.

Signed-off-by: ywqzzy <[email protected]>

Split write and ingest throughput (pingcap#4245)

close pingcap#4243

Signed-off-by: ywqzzy <[email protected]>

fix the problem that expired data was not recycled timely due to slow gc speed (pingcap#4224)

close pingcap#4146

Signed-off-by: ywqzzy <[email protected]>

PageStorage: Fix some bugs (pingcap#4212)

ref pingcap#3594

Signed-off-by: ywqzzy <[email protected]>

Make test of CreateTables using affected opts (pingcap#4239)

close pingcap#4235

Signed-off-by: ywqzzy <[email protected]>

BlobStore: remove the old_ids, not need recycle the blob id. (pingcap#4247)

ref pingcap#3594

Signed-off-by: ywqzzy <[email protected]>

support `PartitionTableScan` in TiFlash (pingcap#3876)

close pingcap#3873

Signed-off-by: ywqzzy <[email protected]>

update.

Signed-off-by: ywqzzy <[email protected]>

update.

Signed-off-by: ywqzzy <[email protected]>

support last_day and dayofmonth pushdown to tiflash (pingcap#4183)

close pingcap#4149

Signed-off-by: ywqzzy <[email protected]>
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make test of CreateTables using affected opts
6 participants