Split write and ingest throughput

[JaySon-Huang]

Signed-off-by: JaySon-Huang [email protected]

What problem does this PR solve?

Issue Number: close #4243

Problem Summary: Now the "Write Throughput By Instance" panel mixes the throughput of write and ingest, which is not easy to check whether the write throughput of each instance is balanced or not. And is not easy to check when we are scaling-in or scaling-out TiFlash instance.

What is changed and how it works?

• Split "write" and "ingest" into different lines in "Write Throughput By Instance"
• Rename "throughput_write" to "throughput_write+ingest" in "Write & Delta Management Throughput" to indicate that include "write" and "ingest" explicitly. Cause we care about foreground write and background delta-management is matched or not in that panel.

Scale-in one node and scale-out another node
Before this PR

After this PR

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
  http://172.16.5.81:21510/d/6svbzVPnk/test-cluster-xxx?orgId=1&from=1646983516172&to=1647007091657
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Make the Grafana panel "Write Throughput By Instance" more explicitly

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• flowbehappy
• lidezhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JaySon-Huang]

/merge

[ti-chi-bot]

@JaySon-Huang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: b740b7a

[sre-bot]

Coverage for changed files

Filename                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Flash/Mpp/MPPTunnel.h                            8                 8     0.00%           8                 8     0.00%          14                14     0.00%           0                 0         -
Storages/Transaction/SchemaBuilder.cpp         835               794     4.91%          46                42     8.70%        1030               958     6.99%         488               468     4.10%
Storages/Transaction/SchemaGetter.h              1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                          844               803     4.86%          55                51     7.27%        1045               973     6.89%         488               468     4.10%

Coverage summary

Functions  MissedFunctions  Executed  Lines   MissedLines  Cover
16853      9456             43.89%    189607  95861        49.44%

full coverage report (for internal network access only)

[JaySon-Huang]

/run-integration-test

[JaySon-Huang]

/rebuild