-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dm: support dump task mode in openapi #11729
Conversation
Hi @River2000i. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@GMHDBJD @lance6716 @D3Hunter PTAL~ |
/ok-to-test |
ut #11361 failed, rerun it |
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11729 +/- ##
================================================
+ Coverage 55.1358% 55.4474% +0.3116%
================================================
Files 1001 1002 +1
Lines 136521 137743 +1222
================================================
+ Hits 75272 76375 +1103
- Misses 55740 55843 +103
- Partials 5509 5525 +16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
"query-status $task_name" \ | ||
"\"stage\": \"Running\"" 1 | ||
|
||
# wait dump task finish |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you check it with get_task_status_check via openapi instead of dmctl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validating json fields in python is a bit complex, I'll create an issue to improve it later...
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, GMHDBJD The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/unhold |
What problem does this PR solve?
Issue Number: close #9230
What is changed and how it works?
make dm_generate_openapi
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note