dm: add a stand-alone load mode #11749
Conversation
not be needed anymore and could be depreciated in the future.
ti-chi-bot
bot
added
first-time-contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/L
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11749 +/- ##
================================================
+ Coverage 53.2223% 55.1517% +1.9293%
================================================
Files 213 1002 +789
Lines 17720 137401 +119681
================================================
+ Hits 9431 75779 +66348
- Misses 7686 56075 +48389
- Partials 603 5547 +4944 |
|
/test engine-integration-test |
|
/test dm-integration-test |
OliverS929
force-pushed
the
2411_dm_modes_rebase
branch
from
d239bf5
to
aacf64d
Compare
|
/retest |
| run_dm_ctl_with_retry $WORK_DIR "127.0.0.1:$MASTER_PORT" \ | ||
| "query-status $task_name_load" 100 \ | ||
| "\"stage\": \"Finished\"" 1 |
There was a problem hiding this comment.
how about adding the sync task after load task finish? For test the complete create DM task
There was a problem hiding this comment.
Yes, we can definitely do that. I actually have a test written in E2E, which I'll submit in a separate PR. How about I also add that test to the OpenAPI test suite along with the E2E PR? Additionally, we could merge the dump test with the existing load test, as the load test above already covers the dump task.
D3Hunter
changed the title
| @@ -287,7 +287,8 @@ func (tm *TaskManager) allFinished(ctx context.Context) bool { | |||
| if runningTask.Unit != frameModel.WorkerDMLoad { | |||
| return false | |||
| } | |||
| case dmconfig.ModeDump: | |||
| case dmconfig.ModeDump, dmconfig.ModeLoad: | |||
There was a problem hiding this comment.
no need to change engine code
| @@ -302,6 +302,9 @@ var workerSeqMap = map[string][]frameModel.WorkerType{ | |||
| dmconfig.ModeDump: { | |||
| frameModel.WorkerDMDump, | |||
| }, | |||
| dmconfig.ModeLoad: { | |||
What problem does this PR solve?
Issue Number: close #9230
What is changed and how it works?
Primary work to add a stand-alone load mode to DM, alongside with dump mode. Load&Sync mode might not be needed anymore and could be depreciated in the future.
UT/IT added are under testing and will be pushed soon.
Continue the work from #11738 as its intended change in openapi conflicted with that of #11729.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
N/A
Do you need to update user documentation, design documentation or monitoring documentation?
Yes. Description of those standalone modes would need to be added to docs for openapi only. Support for dmctl will be delayed further.
Release note