Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM stand-alone dump/load mode and openapi sync stage statusr esponse improvement with TCP connection IO traffic statistics #11754

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

OliverS929
Copy link

What problem does this PR solve?

Issue Number: close #9230

What is changed and how it works?

This is a combined PR from #11749 and #11742, with openapi gen code conflict resolved.

Changes:

  1. Add a stand-alone load mode to DM, alongside with dump mode
  2. Add filed in dm/proto/dmworker.proto and regenerate by make generate-protobuf
  3. Update openapi define and regenerate by make dm_generate_openapi
  4. Init IO counter and uuid for the task created by openapi

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. area/dm Issues or PRs related to DM. labels Nov 15, 2024
@ti-chi-bot ti-chi-bot bot added the area/engine Issues or PRs related to Dataflow Engine. label Nov 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign benmeadowcroft, d3hunter for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 12 lines in your changes missing coverage. Please review.

Project coverage is 55.1633%. Comparing base (68c22f3) to head (d6d6eac).

Additional details and impacted files
Components Coverage Δ
cdc 59.5667% <ø> (∅)
dm 50.0817% <68.5714%> (∅)
engine 53.2449% <0.0000%> (+0.0225%) ⬆️
Flag Coverage Δ
unit 55.1633% <66.6666%> (+1.9410%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #11754        +/-   ##
================================================
+ Coverage   53.2223%   55.1633%   +1.9410%     
================================================
  Files           213       1002       +789     
  Lines         17720     137430    +119710     
================================================
+ Hits           9431      75811     +66380     
- Misses         7686      56071     +48385     
- Partials        603       5548      +4945     

Copy link
Contributor

ti-chi-bot bot commented Nov 15, 2024

@OliverS929: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-dm-integration-test d6d6eac link true /test dm-integration-test
pull-engine-integration-test d6d6eac link true /test engine-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. area/engine Issues or PRs related to Dataflow Engine. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

engine: support new dm task mode
2 participants