cmd: check changefeed start-ts when creating or resuming #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyangfei
added
release-blocker
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #1497 +/- ##
================================================
+ Coverage 49.2311% 49.4028% +0.1716%
================================================
Files 150 150
Lines 15543 15574 +31
================================================
+ Hits 7652 7694 +42
+ Misses 7118 7106 -12
- Partials 773 774 +1 |
|
LGTM |
ti-srebot
approved these changes
Mar 12, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@amyangfei merge failed. |
|
/merge |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Mar 12, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #1499 |
ti-srebot
added a commit
that referenced
this pull request
Mar 12, 2021
Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Add check described in #1150, TODO list item 1
What is changed and how it works?
start-tswith current tso.checkpoint-tswith current tso.Check List
Tests
Release note
start-tsorcheckpoint-ts1 day before current ts.