Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: check changefeed start-ts when creating or resuming (#1497) #1499

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Mar 12, 2021

cherry-pick #1497 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In ticdc repo:
git pr https://github.com/pingcap/ticdc/pull/1499

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/ticdc.git pr/1499:release-4.0-fb8cc9c352c1

What problem does this PR solve?

Add check described in https://github.com/pingcap/ticdc/issues/1150, TODO list item 1

What is changed and how it works?

  • The check is enabled when
    • create a new changefeed, comparing start-ts with current tso.
    • or resume a changefeed, comparing changefeed checkpoint-ts with current tso.
  • The threshold is 1 day

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Add double confirm when creating or resuming changefeed with start-ts or checkpoint-ts 1 day before current ts.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/ptal Could you please take a look? release-blocker This issue blocks a release. Please solve it ASAP. type/4.0-cherry-pick labels Mar 12, 2021
@ti-srebot ti-srebot requested a review from zier-one March 12, 2021 06:05
@ti-srebot ti-srebot added this to the v4.0.12 milestone Mar 12, 2021
@amyangfei amyangfei removed the release-blocker This issue blocks a release. Please solve it ASAP. label Mar 12, 2021
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 12, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 12, 2021
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 63d611e into pingcap:release-4.0 Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants