-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix more events could be sent after a table is removed (#2569) #2577
tests: fix more events could be sent after a table is removed (#2569) #2577
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 1ca416a
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2577 +/- ##
===================================================
+ Coverage 53.7661% 55.5172% +1.7510%
===================================================
Files 153 164 +11
Lines 15958 19711 +3753
===================================================
+ Hits 8580 10943 +2363
- Misses 6475 7715 +1240
- Partials 903 1053 +150 |
This is an automated cherry-pick of #2569
What problem does this PR solve?
Close #2500
The test failure is caused by sending more row changed events to backend sink when a table sink is removed, the close channel way can't terminate table sink at once.
What is changed and how it works?
Use the context to control table sink lifecycle.
Check List
Tests
Release note