-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix more events could be sent after a table is removed #2569
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unstable test fixer! 👍
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 27fe1e6
|
/run-unit-tests |
/run-unit-tests |
Codecov Report
@@ Coverage Diff @@
## master #2569 +/- ##
================================================
+ Coverage 56.0169% 58.4858% +2.4689%
================================================
Files 169 165 -4
Lines 20567 18955 -1612
================================================
- Hits 11521 11086 -435
+ Misses 7921 6853 -1068
+ Partials 1125 1016 -109 |
In response to a cherrypick label: new pull request created: #2577. |
In response to a cherrypick label: new pull request created: #2578. |
In response to a cherrypick label: new pull request created: #2579. |
In response to a cherrypick label: new pull request created: #2580. |
What problem does this PR solve?
Close #2500
The test failure is caused by sending more row changed events to backend sink when a table sink is removed, the close channel way can't terminate table sink at once.
What is changed and how it works?
Use the context to control table sink lifecycle.
Check List
Tests
Release note