Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix more events could be sent after a table is removed #2569

Merged
merged 3 commits into from
Aug 19, 2021

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Close #2500

The test failure is caused by sending more row changed events to backend sink when a table sink is removed, the close channel way can't terminate table sink at once.

What is changed and how it works?

Use the context to control table sink lifecycle.

Check List

Tests

  • Unit test

Release note

None

@amyangfei amyangfei added status/ptal Could you please take a look? component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Aug 19, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 19, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • hi-rustin
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 19, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2021
Copy link
Member

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unstable test fixer! 👍

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 19, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 19, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 27fe1e6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 19, 2021
@amyangfei
Copy link
Contributor Author

/run-unit-tests

@amyangfei
Copy link
Contributor Author

/run-unit-tests
/run-leak-tests
/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2569 (efd3b62) into master (48779ba) will increase coverage by 2.4689%.
The diff coverage is 65.5660%.

@@               Coverage Diff                @@
##             master      #2569        +/-   ##
================================================
+ Coverage   56.0169%   58.4858%   +2.4689%     
================================================
  Files           169        165         -4     
  Lines         20567      18955      -1612     
================================================
- Hits          11521      11086       -435     
+ Misses         7921       6853      -1068     
+ Partials       1125       1016       -109     

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2577.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2578.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2579.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2580.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit test managerSuite.TestManagerAddRemoveTable is not stable
5 participants