Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix more events could be sent after a table is removed (#2569) #2578

Merged
merged 3 commits into from
Aug 21, 2021
Merged

tests: fix more events could be sent after a table is removed (#2569) #2578

merged 3 commits into from
Aug 21, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2569

What problem does this PR solve?

Close #2500

The test failure is caused by sending more row changed events to backend sink when a table sink is removed, the close channel way can't terminate table sink at once.

What is changed and how it works?

Use the context to control table sink lifecycle.

Check List

Tests

  • Unit test

Release note 

None

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 19, 2021
Merged
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved component/test Unit tests and integration tests component. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Aug 19, 2021
@amyangfei amyangfei added this to the v5.0.4 milestone Aug 20, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 21, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 61b1345

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 21, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 61d55eb into pingcap:release-5.0 Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei Awaiting requested review from amyangfei

@liuzix liuzix Awaiting requested review from liuzix

Assignees

@amyangfei amyangfei

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/test Unit tests and integration tests component. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @amyangfei @lonng