-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix more events could be sent after a table is removed (#2569) #2580
tests: fix more events could be sent after a table is removed (#2569) #2580
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 048343a
|
/run-integration-tests |
/run-unit-tests |
Codecov Report
@@ Coverage Diff @@
## release-5.2 #2580 +/- ##
================================================
Coverage ? 55.9212%
================================================
Files ? 169
Lines ? 20663
Branches ? 0
================================================
Hits ? 11555
Misses ? 8002
Partials ? 1106 |
This is an automated cherry-pick of #2569
What problem does this PR solve?
Close #2500
The test failure is caused by sending more row changed events to backend sink when a table sink is removed, the close channel way can't terminate table sink at once.
What is changed and how it works?
Use the context to control table sink lifecycle.
Check List
Tests
Release note