Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add test case to cover varchar default value #2799

Merged
merged 4 commits into from
Sep 25, 2021

Conversation

amyangfei
Copy link
Contributor

What problem does this PR solve?

Add test case to cover #2758

What is changed and how it works?

The case works as follows

  • create a table, executing DML of this table in background
  • alter table add column v1 varchar(20) default "xxx" not null
  • Some of the DMLs could have no field of v1, however when we decode these rows, we should use the new table schema (which has the column of v1, this scenario doesn't break the constraint of online DDL). Since the column doesn't exist, the tidb library will fill in a default value, which is a string type here. This is why we can get either []byte or a string of a column.Value.

Check List

Tests

  • Unit test
  • Integration test

Release note

None

@amyangfei amyangfei added component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. labels Sep 13, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 13, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • 3AceShowHand
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Sep 13, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2021
@amyangfei
Copy link
Contributor Author

/run-all-tests

@amyangfei
Copy link
Contributor Author

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2799 (6a33515) into master (0ebf717) will increase coverage by 1.6887%.
The diff coverage is 56.8954%.

@@               Coverage Diff                @@
##             master      #2799        +/-   ##
================================================
+ Coverage   55.4760%   57.1648%   +1.6887%     
================================================
  Files           165        180        +15     
  Lines         19841      18877       -964     
================================================
- Hits          11007      10791       -216     
+ Misses         7786       7097       -689     
+ Partials       1048        989        -59     

@amyangfei amyangfei added the status/ptal Could you please take a look? label Sep 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 14, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 24, 2021
@amyangfei amyangfei added this to the v5.3.0 milestone Sep 24, 2021
@amyangfei
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6a33515

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 24, 2021
@amyangfei
Copy link
Contributor Author

/run-leak-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor Author

/run-kafka-tests

@amyangfei
Copy link
Contributor Author

/run-kafka-tests

@amyangfei
Copy link
Contributor Author

/run-kafka-tests

2 similar comments
@amyangfei
Copy link
Contributor Author

/run-kafka-tests

@amyangfei
Copy link
Contributor Author

/run-kafka-tests

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2892.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2893.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2894.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #2895.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Unit tests and integration tests component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. needs-cherry-pick-release-5.1 Should cherry pick this PR to release-5.1 branch. needs-cherry-pick-release-5.2 Should cherry pick this PR to release-5.2 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants