-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add test case to cover varchar default value (#2799) #2894
tests: add test case to cover varchar default value (#2799) #2894
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 03d42ab
|
@ti-chi-bot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Codecov Report
@@ Coverage Diff @@
## release-5.1 #2894 +/- ##
================================================
Coverage ? 57.3870%
================================================
Files ? 164
Lines ? 19365
Branches ? 0
================================================
Hits ? 11113
Misses ? 7202
Partials ? 1050 |
This is an automated cherry-pick of #2799
What problem does this PR solve?
Add test case to cover #2758
What is changed and how it works?
The case works as follows
v1
, however when we decode these rows, we should use the new table schema (which has the column ofv1
, this scenario doesn't break the constraint of online DDL). Since the column doesn't exist, the tidb library will fill in a default value, which is astring
type here. This is why we can get either[]byte
or astring
of a column.Value.Check List
Tests
Release note