Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checker(dm): add auto increment id check in optimistic #4636

Merged
merged 7 commits into from
Feb 24, 2022

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Feb 21, 2022

What problem does this PR solve?

Issue Number: ref #3608

#3608 (comment)

What is changed and how it works?

  • add auto increment id check in optimistic

Check List

Tests

  • Unit test

Release note

`None`.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2022
@okJiang okJiang added the area/dm Issues or PRs related to DM. label Feb 21, 2022
@okJiang
Copy link
Member Author

okJiang commented Feb 21, 2022

/cc @lance6716

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2022

Codecov Report

Merging #4636 (dd67eb7) into master (9607554) will increase coverage by 0.0448%.
The diff coverage is 57.5864%.

Flag Coverage Δ
cdc 60.1740% <54.0983%> (+0.2517%) ⬆️
dm 51.9086% <59.2400%> (-0.1203%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master      #4636        +/-   ##
================================================
+ Coverage   55.6402%   55.6850%   +0.0448%     
================================================
  Files           494        507        +13     
  Lines         61283      63139      +1856     
================================================
+ Hits          34098      35159      +1061     
- Misses        23750      24479       +729     
- Partials       3435       3501        +66     

Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 24, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 24, 2022
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dd6060e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2022
@ti-chi-bot
Copy link
Member

@okJiang: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 089c3b2 into pingcap:master Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dm Issues or PRs related to DM. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants