Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*(dm): support MySQL 8.0 collations #4949

Merged
merged 16 commits into from
Mar 28, 2022
Merged

*(dm): support MySQL 8.0 collations #4949

merged 16 commits into from
Mar 28, 2022

Conversation

lance6716
Copy link
Contributor

Signed-off-by: lance6716 [email protected]

What problem does this PR solve?

Issue Number: close #4948

What is changed and how it works?

as title

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch (?)

Release note 

support upstream MySQL 8.0 collations

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 18, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • GMHDBJD
  • liuzix

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 18, 2022
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2022
@lance6716 lance6716 added the area/dm Issues or PRs related to DM. label Mar 18, 2022
@lance6716
Copy link
Contributor Author

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2022
@lance6716 lance6716 mentioned this pull request Mar 18, 2022
Open
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2022
@lance6716 lance6716 mentioned this pull request Mar 21, 2022
Merged
@lance6716
fix sync-diff config
384d16b 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

1 similar comment
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716 lance6716 mentioned this pull request Mar 21, 2022
Open
@lance6716
Copy link
Contributor Author

/run-dm-integration-test

@lance6716
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022
@lance6716
Copy link
Contributor Author

/run-verify

@lance6716
Copy link
Contributor Author

/run-all-tests

@lance6716
Copy link
Contributor Author

lance6716 commented Mar 23, 2022 •
edited
Loading

at least this test always fail

[2022-03-23T07:24:30.179Z]     server_test.go:943: 
[2022-03-23T07:24:30.179Z]         	Error Trace:	server_test.go:943
[2022-03-23T07:24:30.179Z]         	Error:      	Received unexpected error:
[2022-03-23T07:24:30.179Z]         	            	EOF
[2022-03-23T07:24:30.179Z]         	Test:       	TestServerDataLossAfterUnregisterHandle

@liuzix

@lance6716
Copy link
Contributor Author

/run-all-tests

@lance6716
Copy link
Contributor Author

/cc @GMHDBJD @liuzix

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 28, 2022
@lance6716
Copy link
Contributor Author

/cc @D3Hunter

@lance6716
Copy link
Contributor Author

/cc @Ehco1996

GMHDBJD
GMHDBJD approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 28, 2022
@lance6716
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 41c92f5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 28, 2022
Ehco1996
Ehco1996 approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dm/pkg/schema/tracker.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot merged commit 1c86351 into pingcap:master Mar 28, 2022
@lance6716 lance6716 deleted the mysql-8-collation branch October 13, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuzix liuzix liuzix approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@GMHDBJD GMHDBJD GMHDBJD approved these changes

@D3Hunter D3Hunter Awaiting requested review from D3Hunter

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support MySQL 8.0 collations
5 participants
@lance6716 @ti-chi-bot @liuzix @Ehco1996 @GMHDBJD