Fix ResolveLock not called in Scan API #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix resolve lock not called in Scan API Signed-off-by: birdstorm <[email protected]>
birdstorm
added
needs-cherry-pick-2.3
needs-cherry-pick-release-2.4
|
/run-all-tests tidb=v5.0.3 tikv=v5.0.3 pd=v5.0.3 |
Signed-off-by: birdstorm <[email protected]>
|
/run-all-tests tidb=v5.0.3 tikv=v5.0.3 pd=v5.0.3 |
| @@ -115,7 +118,7 @@ public static ByteString bytesGet(ByteString key, Snapshot snapshot) { | |||
| List<Pair<ByteString, ByteString>> fields = new ArrayList<>(); | |||
| while (iterator.hasNext()) { | |||
| Kvrpcpb.KvPair kv = iterator.next(); | |||
| if (kv == null || kv.getKey() == null) { | |||
| if (kv == null || kv.getKey().isEmpty()) { | |||
There was a problem hiding this comment.
Suggested change
| if (kv == null || kv.getKey().isEmpty()) { | |
| if (kv == null || kv.getKey() == null || kv.getKey().isEmpty()) { |
There was a problem hiding this comment.
@marsishandsome key is non-null
|
/merge |
|
cherry pick to release-2.3 in PR #2090 |
|
cherry pick to release-2.4 in PR #2091 |
birdstorm
pushed a commit
that referenced
this pull request
Aug 2, 2021
fix resolve lock not called in Scan API Signed-off-by: birdstorm <[email protected]>
This was referenced Aug 5, 2021
birdstorm
added a commit
that referenced
this pull request
Sep 6, 2021
* fix v2.4 scan bug fix resolve lock not called in Scan API Signed-off-by: birdstorm <[email protected]> * remove backoff Signed-off-by: birdstorm <[email protected]> Co-authored-by: birdstorm <[email protected]>
wfxxh
pushed a commit
to wanfangdata/tispark
that referenced
this pull request
Jun 30, 2023
Signed-off-by: birdstorm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResolveLock was not called in Scan API, it would lead to
table or view not found