Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ResolveLock not called in Scan API (#2089) #2091

Merged
merged 3 commits into from
Sep 6, 2021

Conversation

ti-srebot
Copy link
Collaborator

@ti-srebot ti-srebot commented Jul 30, 2021

cherry-pick #2089 to release-2.4
You can switch your code base to this Pull Request by using git-extras:

# In tispark repo:
git pr https://github.com/pingcap/tispark/pull/2091

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/tispark.git pr/2091:release-2.4-ddbf7d3ff319

ResolveLock was not called in Scan API, it would lead to

  • Sometimes the table/database info was not retrieved from TiKV, e.g., table or view not found
  • Scan API may not get all KV pairs if some of them are locked by another transaction.

fix resolve lock not called in Scan API

Signed-off-by: birdstorm <[email protected]>
Signed-off-by: birdstorm <[email protected]>
@birdstorm
Copy link
Contributor

/run-all-tests

@birdstorm birdstorm merged commit 1effd9a into pingcap:release-2.4 Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CHERRY-PICK cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants