fix null pointer #4102
Merged
fix null pointer #4102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not related to this PR changes but you should update this |
khanhtc1202
reviewed
Jan 5, 2023
| @@ -170,7 +170,7 @@ func (c *client) RunTask(ctx context.Context, taskDefinition types.TaskDefinitio | |||
|
|
|||
| _, err := c.ecsClient.RunTask(ctx, input) | |||
| if err != nil { | |||
| return fmt.Errorf("failed to run ECS task %s: %w", *taskDefinition.TaskDefinitionArn, err) | |||
| return fmt.Errorf("failed to run ECS task %s: %w", *taskDefinition.Family, err) | |||
There was a problem hiding this comment.
Should keep it as is and add a check for TaskDefinicationArn before running task since it doesn't make sense to run a task that does not exist. Please refer to
pipecd/pkg/app/piped/platformprovider/ecs/client.go
Lines 179 to 181 in 21936ef
TonkyH
force-pushed
the
fix/standalone-task
branch
from
b285e6f
to
6f7edd1
Compare
knanao
pushed a commit
that referenced
this pull request
Jan 13, 2023
* fix null pointer * apply review
khanhtc1202
added a commit
that referenced
this pull request
Jan 13, 2023
… (#4128) * Keep new line at end of file in yamlprocessor (#4033) * Keep new line at end of file in yamlprocessor * add a new line to the EOF in case of there is no at EOF * update comment * update eventwatcher_test * consider new line at EOF on parsing kubernetes manifest * update go-yaml v1.9.8 * remove TODO because PR of go-yaml was merged * consider to handle multiple new line at EOF * remove indent vioration of tab * support standalone ECS task (#4084) Fixes #2734 * Small lint fix (#4097) * fix null pointer (#4102) * fix null pointer * apply review * Add example for ecs standalone task (#4104) * add example for ecs standalone task * add example for ecs standalone task * wip * add yaml example to docs. * add example for ecs standalone task * wip * add yaml example to docs. * apply review * Update docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Khanh Tran <[email protected]> * Add update contributions command (#4114) * Add update contributions command * Update hack/gen-contributions.sh * Run update go deps (#4117) * feature: cli and grpc to disable application (#4119) * Add new line in detailsFormat to fix plan preview format (#4122) * add document how to disable (#4123) Co-authored-by: Kurochan <[email protected]> Co-authored-by: Tomoki Hori <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: kevin55156 <[email protected]> Co-authored-by: Yoshiaki Ishihara <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The null pointer was causing the error propagation to not work.
So I've corrected it.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: