Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update contributions command #4114

Merged
merged 3 commits into from
Jan 10, 2023
Merged

Add update contributions command #4114

merged 3 commits into from
Jan 10, 2023

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Jan 6, 2023

What this PR does / why we need it:

We can update the contributions session on README.md using command

$ make gen/contributions

Also update the README to add missing contributors (welcome @TonkyH and @funera1 👏 )

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

hack/gen-contributions.sh Outdated Show resolved Hide resolved
@khanhtc1202 khanhtc1202 enabled auto-merge (squash) January 6, 2023 09:08
hack/gen-contributions.sh Outdated Show resolved Hide resolved
@knanao
Copy link
Member

knanao commented Jan 10, 2023

I'm glad if it works automatically as a github actions. 🙌

@khanhtc1202 khanhtc1202 merged commit d562cf6 into master Jan 10, 2023
@khanhtc1202 khanhtc1202 deleted the add-contributions branch January 10, 2023 02:19
knanao pushed a commit that referenced this pull request Jan 13, 2023
* Add update contributions command

* Update hack/gen-contributions.sh
khanhtc1202 added a commit that referenced this pull request Jan 13, 2023
… (#4128)

* Keep new line at end of file in yamlprocessor (#4033)

* Keep new line at end of file in yamlprocessor

* add a new line to the EOF in case of there is no  at EOF

* update comment

* update eventwatcher_test

* consider new line at EOF on parsing kubernetes manifest

* update go-yaml v1.9.8

* remove TODO because PR of go-yaml was merged

* consider to handle multiple new line at EOF

* remove indent vioration of tab

* support standalone ECS task (#4084)

Fixes #2734

* Small lint fix (#4097)

* fix null pointer (#4102)

* fix null pointer

* apply review

* Add example for ecs standalone task (#4104)

* add example for ecs standalone task

* add example for ecs standalone task

* wip

* add yaml example to docs.

* add example for ecs standalone task

* wip

* add yaml example to docs.

* apply review

* Update docs/content/en/docs-dev/user-guide/managing-application/defining-app-configuration/ecs.md

Co-authored-by: Khanh Tran <[email protected]>

Co-authored-by: Khanh Tran <[email protected]>

* Add update contributions command (#4114)

* Add update contributions command

* Update hack/gen-contributions.sh

* Run update go deps (#4117)

* feature: cli and grpc to disable application (#4119)

* Add new line in detailsFormat to fix plan preview format (#4122)

* add document how to disable (#4123)

Co-authored-by: Kurochan <[email protected]>
Co-authored-by: Tomoki Hori <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: kevin55156 <[email protected]>
Co-authored-by: Yoshiaki Ishihara <[email protected]>
This was referenced Feb 7, 2023
@github-actions github-actions bot mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants