Add spec autoCreateNamespace configuration for creating a ns when doesn't exist #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hungran
requested review from
nghialv,
khanhtc1202 and
kentakozuka
as code owners
…'t exist Signed-off-by: hungran <[email protected]>
hungran
force-pushed
the
hungran/autoCreateNamespace
branch
from
7d9c089
to
f68861e
Compare
khanhtc1202
changed the title
khanhtc1202
reviewed
Jul 21, 2023
khanhtc1202
reviewed
Jul 21, 2023
khanhtc1202
reviewed
Jul 21, 2023
khanhtc1202
reviewed
Jul 21, 2023
hungran
commented
Jul 21, 2023
Signed-off-by: hungran <[email protected]> Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]> Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
* Redirect /docs/ to /docs-{latest}/
Signed-off-by: Kenta Kozuka <[email protected]>
* Fix use local path
Signed-off-by: Kenta Kozuka <[email protected]>
---------
Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]>
Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]>
Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]>
Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]>
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: hungran <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: hungran <[email protected]>
Signed-off-by: seitarof <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]>
* Update go test command Signed-off-by: khanhtc1202 <[email protected]> * Update makefile and github action command Signed-off-by: khanhtc1202 <[email protected]> * Revert gitignore Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: hungran <[email protected]>
…cd#4513) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: hungran <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: hungran <[email protected]>
* Add Google Tag Manager to the site Signed-off-by: Kenta Kozuka <[email protected]> * Add breakline Signed-off-by: Kenta Kozuka <[email protected]> * Add breakline Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: hungran <[email protected]>
khanhtc1202
reviewed
Jul 22, 2023
| @@ -36,3 +37,4 @@ spec: | |||
| helmValueFiles: | |||
| - values.yaml | |||
| helmVersion: 3.1.1 | |||
| autoCreateNamespace: false | |||
There was a problem hiding this comment.
Default is false so no need to add this
khanhtc1202
reviewed
Jul 22, 2023
pkg/config/application_test.go
Outdated
| @@ -613,7 +618,8 @@ func TestGenericAnalysisConfiguration(t *testing.T) { | |||
| }, | |||
| }, | |||
| Input: KubernetesDeploymentInput{ | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoCreateNamespace: false, | |||
There was a problem hiding this comment.
Default is false so no need to add this
khanhtc1202
reviewed
Jul 22, 2023
pkg/config/application_test.go
Outdated
| @@ -493,7 +497,8 @@ func TestGenericPostSyncConfiguration(t *testing.T) { | |||
| }, | |||
| }, | |||
| Input: KubernetesDeploymentInput{ | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoCreateNamespace: false, | |||
There was a problem hiding this comment.
Default is false so no need to add this
khanhtc1202
reviewed
Jul 22, 2023
pkg/config/application_test.go
Outdated
| @@ -395,7 +397,8 @@ func TestTrueByDefaultBoolConfiguration(t *testing.T) { | |||
| }, | |||
| }, | |||
| Input: KubernetesDeploymentInput{ | |||
| AutoRollback: newBoolPointer(false), | |||
| AutoRollback: newBoolPointer(false), | |||
| AutoCreateNamespace: false, | |||
There was a problem hiding this comment.
Default is false so no need to add this
khanhtc1202
reviewed
Jul 22, 2023
pkg/config/application_test.go
Outdated
| @@ -315,7 +315,8 @@ func TestGenericTriggerConfiguration(t *testing.T) { | |||
| }, | |||
| }, | |||
| Input: KubernetesDeploymentInput{ | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoCreateNamespace: false, | |||
There was a problem hiding this comment.
Default is false so no need to add this
khanhtc1202
reviewed
Jul 22, 2023
pkg/config/application_test.go
Outdated
| @@ -366,7 +367,8 @@ func TestTrueByDefaultBoolConfiguration(t *testing.T) { | |||
| }, | |||
| }, | |||
| Input: KubernetesDeploymentInput{ | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoCreateNamespace: false, | |||
There was a problem hiding this comment.
Default is false so no need to add this
khanhtc1202
reviewed
Jul 22, 2023
| @@ -97,7 +97,8 @@ func TestKubernetesApplicationConfig(t *testing.T) { | |||
| }, | |||
| }, | |||
| Input: KubernetesDeploymentInput{ | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoCreateNamespace: false, | |||
There was a problem hiding this comment.
Default is false so no need to add this
khanhtc1202
reviewed
Jul 22, 2023
| @@ -135,7 +136,8 @@ func TestKubernetesApplicationConfig(t *testing.T) { | |||
| }, | |||
| }, | |||
| Input: KubernetesDeploymentInput{ | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoRollback: newBoolPointer(true), | |||
| AutoCreateNamespace: false, | |||
There was a problem hiding this comment.
Default is false so no need to add this
khanhtc1202
reviewed
Jul 22, 2023
| a.platformProvider.KubeConfigPath, | ||
| a.getNamespaceToRun(manifest.Key), | ||
| ) | ||
| if err != nil && !errors.Is(err, errReplaceAlreadyExists) { |
There was a problem hiding this comment.
Rename due to #4504 (comment)
khanhtc1202
reviewed
Jul 22, 2023
| a.platformProvider.KubeConfigPath, | ||
| a.getNamespaceToRun(manifest.Key), | ||
| ) | ||
| if err != nil && !errors.Is(err, errReplaceAlreadyExists) { |
There was a problem hiding this comment.
Rename due to #4504 (comment)
khanhtc1202
reviewed
Jul 22, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4504 +/- ##
==========================================
- Coverage 30.03% 29.99% -0.05%
==========================================
Files 220 220
Lines 25761 25796 +35
==========================================
Hits 7737 7737
- Misses 17379 17414 +35
Partials 645 645
☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Jul 22, 2023
| @@ -81,6 +92,17 @@ func (a *applier) CreateManifest(ctx context.Context, manifest Manifest) error { | |||
| return a.initErr | |||
| } | |||
|
|
|||
| if a.input.AutoCreateNamespace == true { | |||
There was a problem hiding this comment.
Suggested change
| if a.input.AutoCreateNamespace == true { | |
| if a.input.AutoCreateNamespace { |
| @@ -64,6 +64,17 @@ func (a *applier) ApplyManifest(ctx context.Context, manifest Manifest) error { | |||
| return a.initErr | |||
| } | |||
|
|
|||
| if a.input.AutoCreateNamespace == true { | |||
There was a problem hiding this comment.
Suggested change
| if a.input.AutoCreateNamespace == true { | |
| if a.input.AutoCreateNamespace { |
Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
|
@hungran Could you check the false test 🙏 |
Signed-off-by: hungran <[email protected]>
@khanhtc1202 yeah, I might missed run the test after changed the test file, fixed |
khanhtc1202
reviewed
Jul 23, 2023
| @@ -22,6 +22,7 @@ spec: | |||
| helmValueFiles: | |||
| - values.yaml | |||
| helmVersion: 3.1.1 | |||
| autoCreateNamespace: true | |||
There was a problem hiding this comment.
I think no, will remove it :) thanks
Signed-off-by: hungran <[email protected]>
Merged
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
…sn't exist (pipe-cd#4504) * feat: add spec input.AutoCreateNamespace for creating a ns when doesn't exist Signed-off-by: hungran <[email protected]> * not return error when namespace already exists Signed-off-by: hungran <[email protected]> Signed-off-by: hungran <[email protected]> * not return err Signed-off-by: hungran <[email protected]> * WIP Signed-off-by: hungran <[email protected]> Signed-off-by: hungran <[email protected]> * omitempty AutoCreateNamespace, add test case Signed-off-by: hungran <[email protected]> * test data k8s-app-helm.yaml Signed-off-by: hungran <[email protected]> * Redirect /docs/ to /docs-{latest}/ (pipe-cd#4495) * Redirect /docs/ to /docs-{latest}/ Signed-off-by: Kenta Kozuka <[email protected]> * Fix use local path Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: hungran <[email protected]> * Fix documentation link is not displayed (pipe-cd#4505) Signed-off-by: hungran <[email protected]> * Update docs/content/en/docs-dev/user-guide/configuration-reference.md Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]> * Update pkg/config/application_kubernetes.go Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]> * Update pkg/config/application_kubernetes_test.go Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]> * Update pkg/config/application_test.go Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]> * Bump word-wrap from 1.2.3 to 1.2.4 in /web (pipe-cd#4511) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: hungran <[email protected]> * Setup codecov (pipe-cd#4509) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: hungran <[email protected]> * add: caution note to user group doc (pipe-cd#4512) Signed-off-by: seitarof <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Signed-off-by: hungran <[email protected]> * Update go test command (pipe-cd#4514) * Update go test command Signed-off-by: khanhtc1202 <[email protected]> * Update makefile and github action command Signed-off-by: khanhtc1202 <[email protected]> * Revert gitignore Signed-off-by: khanhtc1202 <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: hungran <[email protected]> * Fix make release/docs command regenerate unused docs directory (pipe-cd#4513) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: hungran <[email protected]> * Update auth docs (pipe-cd#4517) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: hungran <[email protected]> * Add Google Tag Manager to the site (pipe-cd#4519) * Add Google Tag Manager to the site Signed-off-by: Kenta Kozuka <[email protected]> * Add breakline Signed-off-by: Kenta Kozuka <[email protected]> * Add breakline Signed-off-by: Kenta Kozuka <[email protected]> --------- Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: hungran <[email protected]> * Update pkg/config/application_kubernetes_test.go Signed-off-by: hungran <[email protected]> * Update pkg/config/application_test.go Signed-off-by: hungran <[email protected]> * Update pkg/config/application_test.go Signed-off-by: hungran <[email protected]> * Update pkg/config/application_test.go Signed-off-by: hungran <[email protected]> * Update pkg/config/application_test.go Signed-off-by: hungran <[email protected]> * Update pkg/config/application_test.go Signed-off-by: hungran <[email protected]> * get value from var not from pointer Signed-off-by: hungran <[email protected]> * handle error when namespace already exsist and ignore it Signed-off-by: hungran <[email protected]> * rename handle err, remove unessacarry value test Signed-off-by: hungran <[email protected]> * if true Signed-off-by: hungran <[email protected]> * fix test data Signed-off-by: hungran <[email protected]> * fix correct the test case Signed-off-by: hungran <[email protected]> * remove unuse value in k8s-app-helm Signed-off-by: hungran <[email protected]> --------- Signed-off-by: hungran <[email protected]> Signed-off-by: hungran <[email protected]> Signed-off-by: Kenta Kozuka <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: seitarof <[email protected]> Co-authored-by: Kenta Kozuka <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Seitaro Fujigaki <[email protected]> Signed-off-by: moko-poi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
hey team, I'm new here so really need your help and correct me if I'm wrong on smt
this PR will try to use
kubectl create namespace <ns_name>when we put flagAutoCreateNamespaceto avoid issue when the ns doesn't exitbasis I created field
AutoCreateNamespaceunderKubernetesDeploymentInputfollowing this comment Add --create-namespace flag when uses helm version greater than v3 #4150 (review)Which issue(s) this PR fixes: #1202
Fixes #
Does this PR introduce a user-facing change?: N/A