Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Tag Manager to the site #4519

Merged
merged 3 commits into from
Jul 21, 2023
Merged

Conversation

kentakozuka
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (80d45ec) 29.99% compared to head (88dc556) 30.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4519      +/-   ##
==========================================
+ Coverage   29.99%   30.03%   +0.03%     
==========================================
  Files         220      220              
  Lines       25761    25761              
==========================================
+ Hits         7727     7737      +10     
+ Misses      17388    17379       -9     
+ Partials      646      645       -1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you go 🫡

@kentakozuka kentakozuka merged commit 824f9c0 into pipe-cd:master Jul 21, 2023
@kentakozuka kentakozuka deleted the gtm branch July 21, 2023 02:16
hungran pushed a commit to hungran/pipecd that referenced this pull request Jul 21, 2023
* Add Google Tag Manager to the site

Signed-off-by: Kenta Kozuka <[email protected]>

* Add breakline

Signed-off-by: Kenta Kozuka <[email protected]>

* Add breakline

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: hungran <[email protected]>
khanhtc1202 added a commit that referenced this pull request Jul 24, 2023
…sn't exist (#4504)

* feat: add spec input.AutoCreateNamespace for creating a ns when doesn't exist

Signed-off-by: hungran <[email protected]>

* not return error when namespace already exists

Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>

* not return err

Signed-off-by: hungran <[email protected]>

* WIP
Signed-off-by: hungran <[email protected]>

Signed-off-by: hungran <[email protected]>

* omitempty AutoCreateNamespace, add test case

Signed-off-by: hungran <[email protected]>

* test data k8s-app-helm.yaml

Signed-off-by: hungran <[email protected]>

* Redirect /docs/ to /docs-{latest}/ (#4495)

* Redirect /docs/ to /docs-{latest}/

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix use local path

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: hungran <[email protected]>

* Fix documentation link is not displayed (#4505)

Signed-off-by: hungran <[email protected]>

* Update docs/content/en/docs-dev/user-guide/configuration-reference.md

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_kubernetes.go

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_kubernetes_test.go

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Bump word-wrap from 1.2.3 to 1.2.4 in /web (#4511)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: hungran <[email protected]>

* Setup codecov (#4509)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: hungran <[email protected]>

* add: caution note to user group doc (#4512)

Signed-off-by: seitarof <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update go test command (#4514)

* Update go test command

Signed-off-by: khanhtc1202 <[email protected]>

* Update makefile and github action command

Signed-off-by: khanhtc1202 <[email protected]>

* Revert gitignore

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: hungran <[email protected]>

* Fix make release/docs command regenerate unused docs directory (#4513)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update auth docs (#4517)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: hungran <[email protected]>

* Add Google Tag Manager to the site (#4519)

* Add Google Tag Manager to the site

Signed-off-by: Kenta Kozuka <[email protected]>

* Add breakline

Signed-off-by: Kenta Kozuka <[email protected]>

* Add breakline

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_kubernetes_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* get value from var not from pointer

Signed-off-by: hungran <[email protected]>

* handle error when namespace already exsist and ignore it

Signed-off-by: hungran <[email protected]>

* rename handle err, remove unessacarry value test

Signed-off-by: hungran <[email protected]>

* if true

Signed-off-by: hungran <[email protected]>

* fix test data

Signed-off-by: hungran <[email protected]>

* fix correct the test case

Signed-off-by: hungran <[email protected]>

* remove unuse value in k8s-app-helm

Signed-off-by: hungran <[email protected]>

---------

Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: seitarof <[email protected]>
Co-authored-by: Kenta Kozuka <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Seitaro Fujigaki <[email protected]>
kentakozuka added a commit to kentakozuka/pipecd that referenced this pull request Jul 28, 2023
kentakozuka added a commit to kentakozuka/pipecd that referenced this pull request Jul 28, 2023
khanhtc1202 pushed a commit that referenced this pull request Jul 31, 2023
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
sZma5a pushed a commit to sZma5a/pipecd that referenced this pull request Aug 27, 2023
)

This reverts commit 824f9c0.

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: sZma5a <[email protected]>
moko-poi pushed a commit to moko-poi/pipecd that referenced this pull request Nov 3, 2023
…sn't exist (pipe-cd#4504)

* feat: add spec input.AutoCreateNamespace for creating a ns when doesn't exist

Signed-off-by: hungran <[email protected]>

* not return error when namespace already exists

Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>

* not return err

Signed-off-by: hungran <[email protected]>

* WIP
Signed-off-by: hungran <[email protected]>

Signed-off-by: hungran <[email protected]>

* omitempty AutoCreateNamespace, add test case

Signed-off-by: hungran <[email protected]>

* test data k8s-app-helm.yaml

Signed-off-by: hungran <[email protected]>

* Redirect /docs/ to /docs-{latest}/ (pipe-cd#4495)

* Redirect /docs/ to /docs-{latest}/

Signed-off-by: Kenta Kozuka <[email protected]>

* Fix use local path

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: hungran <[email protected]>

* Fix documentation link is not displayed (pipe-cd#4505)

Signed-off-by: hungran <[email protected]>

* Update docs/content/en/docs-dev/user-guide/configuration-reference.md

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_kubernetes.go

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_kubernetes_test.go

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Bump word-wrap from 1.2.3 to 1.2.4 in /web (pipe-cd#4511)

Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4.
- [Release notes](https://github.com/jonschlinkert/word-wrap/releases)
- [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4)

---
updated-dependencies:
- dependency-name: word-wrap
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: hungran <[email protected]>

* Setup codecov (pipe-cd#4509)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: hungran <[email protected]>

* add: caution note to user group doc (pipe-cd#4512)

Signed-off-by: seitarof <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update go test command (pipe-cd#4514)

* Update go test command

Signed-off-by: khanhtc1202 <[email protected]>

* Update makefile and github action command

Signed-off-by: khanhtc1202 <[email protected]>

* Revert gitignore

Signed-off-by: khanhtc1202 <[email protected]>

---------

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: hungran <[email protected]>

* Fix make release/docs command regenerate unused docs directory (pipe-cd#4513)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update auth docs (pipe-cd#4517)

Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: hungran <[email protected]>

* Add Google Tag Manager to the site (pipe-cd#4519)

* Add Google Tag Manager to the site

Signed-off-by: Kenta Kozuka <[email protected]>

* Add breakline

Signed-off-by: Kenta Kozuka <[email protected]>

* Add breakline

Signed-off-by: Kenta Kozuka <[email protected]>

---------

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_kubernetes_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* Update pkg/config/application_test.go

Signed-off-by: hungran <[email protected]>

* get value from var not from pointer

Signed-off-by: hungran <[email protected]>

* handle error when namespace already exsist and ignore it

Signed-off-by: hungran <[email protected]>

* rename handle err, remove unessacarry value test

Signed-off-by: hungran <[email protected]>

* if true

Signed-off-by: hungran <[email protected]>

* fix test data

Signed-off-by: hungran <[email protected]>

* fix correct the test case

Signed-off-by: hungran <[email protected]>

* remove unuse value in k8s-app-helm

Signed-off-by: hungran <[email protected]>

---------

Signed-off-by: hungran <[email protected]>
Signed-off-by: hungran <[email protected]>
Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: seitarof <[email protected]>
Co-authored-by: Kenta Kozuka <[email protected]>
Co-authored-by: Khanh Tran <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Seitaro Fujigaki <[email protected]>
Signed-off-by: moko-poi <[email protected]>
moko-poi pushed a commit to moko-poi/pipecd that referenced this pull request Nov 3, 2023
)

This reverts commit 824f9c0.

Signed-off-by: Kenta Kozuka <[email protected]>
Signed-off-by: moko-poi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants