-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note to RELEASE file #5149
Add note to RELEASE file #5149
Conversation
Signed-off-by: khanhtc1202 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5149 +/- ##
=======================================
Coverage 22.79% 22.79%
=======================================
Files 412 412
Lines 43827 43827
=======================================
+ Hits 9989 9992 +3
+ Misses 33050 33047 -3
Partials 788 788 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good note👍
make release/init
worked well even after fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]>
* Add note to RELEASE file (#5149) Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Fix the kubernetes manifest diff (#5154) * Add TestLoadAndDiff Signed-off-by: Shinnosuke Sawada <[email protected]> * Make testcase smaller Signed-off-by: Shinnosuke Sawada <[email protected]> * Separate test cases Signed-off-by: Shinnosuke Sawada <[email protected]> * Add test cases Signed-off-by: Shinnosuke Sawada <[email protected]> * FIx the k8s diff normalize both of old and new manifests Signed-off-by: Shinnosuke Sawada <[email protected]> * Rename the testcase Signed-off-by: Shinnosuke Sawada <[email protected]> --------- Signed-off-by: Shinnosuke Sawada <[email protected]> Signed-off-by: pipecd-bot <[email protected]> * Release v0.48.7 (#5157) Signed-off-by: Shinnosuke Sawada <[email protected]> Signed-off-by: pipecd-bot <[email protected]> --------- Signed-off-by: khanhtc1202 <[email protected]> Signed-off-by: pipecd-bot <[email protected]> Signed-off-by: Shinnosuke Sawada <[email protected]> Co-authored-by: Khanh Tran <[email protected]> Co-authored-by: Shinnosuke Sawada-Dazai <[email protected]>
What this PR does / why we need it:
Add note to aware release facilitator to use
make release
command instead of update this file manually 😅Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: