Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #5149 #5154 #5157 #5160

Merged

Conversation

github-actions[bot]
Copy link
Contributor

What this PR does / why we need it:
Cherry pick of #5149 #5154 #5157.

khanhtc1202 and others added 3 commits August 26, 2024 06:27
Signed-off-by: khanhtc1202 <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
* Add TestLoadAndDiff

Signed-off-by: Shinnosuke Sawada <[email protected]>

* Make testcase smaller

Signed-off-by: Shinnosuke Sawada <[email protected]>

* Separate test cases

Signed-off-by: Shinnosuke Sawada <[email protected]>

* Add test cases

Signed-off-by: Shinnosuke Sawada <[email protected]>

* FIx the k8s diff

normalize both of old and new manifests

Signed-off-by: Shinnosuke Sawada <[email protected]>

* Rename the testcase

Signed-off-by: Shinnosuke Sawada <[email protected]>

---------

Signed-off-by: Shinnosuke Sawada <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
Signed-off-by: Shinnosuke Sawada <[email protected]>
Signed-off-by: pipecd-bot <[email protected]>
@Warashi
Copy link
Contributor

Warashi commented Aug 26, 2024

Close and reopen to run the workflows.

@Warashi Warashi closed this Aug 26, 2024
@Warashi Warashi reopened this Aug 26, 2024
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 22.53%. Comparing base (f921374) to head (188c469).
Report is 1 commits behind head on release-v0.48.x.

Files Patch % Lines
pkg/app/piped/platformprovider/kubernetes/diff.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release-v0.48.x    #5160      +/-   ##
===================================================
+ Coverage            22.50%   22.53%   +0.02%     
===================================================
  Files                  519      519              
  Lines                56917    56923       +6     
===================================================
+ Hits                 12812    12830      +18     
+ Misses               43077    43064      -13     
- Partials              1028     1029       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi merged commit 9dc5c4d into release-v0.48.x Aug 26, 2024
17 checks passed
@Warashi Warashi deleted the cherry-pick-#5149-#5154-#5157-to-release-v0.48.x branch August 26, 2024 06:58
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants