Using numpy.random.RandomState instead of numpy.random in LDA #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droudy
changed the title
|
Please add tests for this particular function(checking both initializaitons work). Also need to update existing tests that fix random seed to use this new API, for example https://github.com/RaRe-Technologies/gensim/blob/develop/gensim/test/test_ldamodel.py#L253 |
|
Just need to add |
topcis, topn -> num_topics, num_words to match LdaModel
| @@ -586,6 +586,7 @@ def show_topics(self, num_topics=10, num_words=10, log=False, formatted=True): | |||
| if num_topics < 0: | |||
| num_topics = len(self.data) | |||
|
|
|||
|
|
|||
| def testRandomState(): | ||
| testcases = [numpy.random.seed(0), None, numpy.random.RandomState(0), 0] | ||
| for testcase in testcases: | ||
| assert(isinstance(ldamodel.check_random_state(testcase), numpy.random.RandomState)) |
There was a problem hiding this comment.
add a test assertEqual(ldamodel.check_random_state(testcase), numpy.random.RandomState(0))
| @@ -97,7 +98,7 @@ def testAlpha(self): | |||
| expected_shape = (2,) | |||
|
|
|||
| # should not raise anything | |||
| self.class_(**kwargs) | |||
| self.class_(**kwarghs) | |||
|
@piskvorky it was an accident, it was fixed in 8ea4d58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #113 , a random_state parameter has been added to the LdaState initializer and a check_random_seed method as well to check the seed. The check_random_state method was taken from maciejkula/glove-python@95a04af , should I rewrite the method?