-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using numpy.random.RandomState instead of numpy.random in LDA #748
Merged
Merged
Changes from 23 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
1c63c9a
Merge branch 'release-0.12.3rc1'
tmylk 280a488
Merge branch 'release-0.12.3'
tmylk ddeb002
Merge branch 'release-0.12.3'
tmylk f2ac3a9
Update CHANGELOG.txt
tmylk cf09e8c
Update CHANGELOG.txt
tmylk b61287a
resolve merge conflict in Changelog
tmylk 3ade404
Merge branch 'release-0.12.4' with #596
tmylk 9e6522e
Merge branch 'release-0.13.0'
tmylk 87c4e9c
Merge branch 'release-0.13.0'
tmylk 9c74b40
Release version typo fix
tmylk 7b30025
Merge branch 'release-0.13.0rc1'
tmylk 716d25d
numpy.random -> numpy.random_state
droudy a19d9b1
change added
droudy b4311d0
added some documentation
droudy 6ae98a1
fixed type
droudy de79c8e
Merge branch 'release-0.13.0'
tmylk 77bb575
Updated tests to use new api
droudy 78c9961
Added a test for check_random_state?
droudy 6606ab2
Added test for check_random_state?
droudy d4f9cc5
Merge branch 'release-0.13.1'
tmylk f5a749c
topcis, topn -> num_topics, num_words to match LdaModel
droudy c9369ea
Merge pull request #1 from droudy/param-change
droudy 78d8072
Parameter change in test_dtm for show_topics
droudy 7f5515a
Added a test for check_random_state?
droudy 0648827
topcis, topn -> num_topics, num_words to match LdaModel
droudy f6e5771
Merge branch 'develop' of https://github.com/droudy/gensim into develop
droudy 3fd444c
random_state parameter added to ldamulticore
droudy 238d537
Merge remote-tracking branch 'upstream/master' into droudy-patch-1
droudy 35a45e4
Merge remote-tracking branch 'upstream/develop' into develop
droudy c69f9c4
Merge branch 'develop' into droudy-patch-1
droudy 8ea4d58
typo
droudy 75815a5
removed extra line
droudy 6d8c2f9
check_random_state() changed to get_random_state()
droudy 98786ed
Another assert added to test
droudy d46284a
updated method call
droudy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,6 +47,7 @@ def testfile(): | |
# temporary data will be stored to this file | ||
return os.path.join(tempfile.gettempdir(), 'gensim_models.tst') | ||
|
||
|
||
def testRandomState(): | ||
testcases = [numpy.random.seed(0), None, numpy.random.RandomState(0), 0] | ||
for testcase in testcases: | ||
|
@@ -97,7 +98,7 @@ def testAlpha(self): | |
expected_shape = (2,) | ||
|
||
# should not raise anything | ||
self.class_(**kwargs) | ||
self.class_(**kwarghs) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
kwargs['alpha'] = 'symmetric' | ||
model = self.class_(**kwargs) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the line