Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Extension crashes when passing large data to jq (1.7.16-beta.8) #4964

Closed
twschiller opened this issue Jan 6, 2023 · 3 comments · Fixed by #6579
Closed

Browser Extension crashes when passing large data to jq (1.7.16-beta.8) #4964

twschiller opened this issue Jan 6, 2023 · 3 comments · Fixed by #6579
Assignees
Labels
bug Something isn't working customer Required for a customer projct mv3 runtime

Comments

@twschiller
Copy link
Contributor

twschiller commented Jan 6, 2023

Context

Steps to Reproduce

  • Add this brick to a trigger: @pixies/4964-repro-brick
  • Run the trigger
  • Open the sidebar

Discussion

Investigation

  • Looks like a memory leak and/or absurd CPU utilization
  • Might be related to M1. Federico is not able to product, and it didn't come up during 1.7.15 testing on my Intel Mac
@twschiller twschiller added bug Something isn't working runtime release blocker labels Jan 6, 2023
@twschiller twschiller added this to the 1.7.16 milestone Jan 6, 2023
@twschiller twschiller added the customer Required for a customer projct label Jan 6, 2023
@twschiller twschiller changed the title Browser Extension Crashes on customer internal site (1.7.16-beta.8) Browser Extension crashes (1.7.16-beta.8) Jan 6, 2023
@twschiller twschiller changed the title Browser Extension crashes (1.7.16-beta.8) Browser Extension crashes when passing large data to jq (1.7.16-beta.8) Jan 6, 2023
@twschiller
Copy link
Contributor Author

twschiller commented Jan 6, 2023

It works for me on main on my M1 Mac if I modify the jq brick to not use the sandbox.

So there’s probably one of two things happening (or both):

@fregante
Copy link
Contributor

fregante commented Jan 6, 2023

Heads up: these are just my assumptions and may not be factual.


The second part could be possible:

  • frames might have memory limitations, usually for third party origins, but ideally not for extensions

If that's not the case, I can't think of anything else because:

  • the sandbox isn't special in any other way, it's just a local page served from Chrome-extension:// just like others, except without Chrome.* APIs
  • if the frame isn't compute-limited, potentially it's even better than in-content-script evaluation because it's a whole new "thread". This means it should be able to stall without blocking the main loop. I suppose it can still crash the tab though.

@corinnemayans
Copy link
Contributor

@twschiller - I'm removing the milestone on this one because it is old and I'm closing that milestone. Probably need to add a new milestone to this one unless this issue should be closed out with the old one.

@corinnemayans corinnemayans removed this from the 2023 - Week 02 milestone Jan 20, 2023
@fregante fregante removed their assignment Jan 28, 2023
@twschiller twschiller removed their assignment Jun 13, 2023
@fregante fregante self-assigned this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Required for a customer projct mv3 runtime
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants