#4964: Permanently move JQ out of sandbox #6579
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6579 +/- ##
=======================================
Coverage 70.05% 70.06%
=======================================
Files 1175 1176 +1
Lines 36624 36621 -3
Branches 6913 6913
=======================================
+ Hits 25656 25657 +1
+ Misses 10968 10964 -4
☔ View full report in Codecov by Sentry. |
src/utils/jq.ts
Outdated
| filter: string; | ||
| }; | ||
|
|
||
| export async function applyJq(payload: ApplyJqPayload) { |
There was a problem hiding this comment.
I think we can just move this back into the jq.ts brick module because that's the only place it's called now
There was a problem hiding this comment.
@fregante thanks - see comment about consolidating into the jq.ts file: https://github.com/pixiebrix/pixiebrix-extension/pull/6579/files#r1342959845
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
What does this PR do?
JQ hasn't been run in the sandbox since #4972. On Slack, Todd and I figured that maybe JQ doesn't actually need to run in the sandbox even in MV3, so I'm moving it out permanently.
I think this comment was the reason why it was added to the sandbox in the first place:
Related
Checklist