Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7809: Fix Edge sidePanel links crash bug #7889

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Conversation

fregante
Copy link
Contributor

What does this PR do?

Checklist

@fregante fregante added bug Something isn't working edge MS Edge Chromium support labels Mar 11, 2024
@twschiller twschiller added this to the 1.8.11 milestone Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 72.66%. Comparing base (90f1f5a) to head (c648359).
Report is 14 commits behind head on main.

Files Patch % Lines
src/utils/openAllLinksInPopups.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7889      +/-   ##
==========================================
- Coverage   72.67%   72.66%   -0.01%     
==========================================
  Files        1290     1290              
  Lines       40176    40176              
  Branches     7478     7478              
==========================================
- Hits        29197    29195       -2     
- Misses      10979    10981       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@twschiller
Copy link
Contributor

twschiller commented Mar 11, 2024

@fregante still crashing for me. I don't think that code is running? If I do the following it never gets hit:

Which version/build of MS Edge are you trying on?

image

@fregante
Copy link
Contributor Author

122.0.2365.63

I can reproduce the crashing too, but only sometimes

Screen.Recording.4.mov

@fregante
Copy link
Contributor Author

fregante commented Mar 11, 2024

event.target was sometimes the SVG path element, so link was false. It seems to work reliably now

@twschiller twschiller enabled auto-merge (squash) March 11, 2024 23:54
@twschiller
Copy link
Contributor

image

@twschiller
Copy link
Contributor

event.target was sometimes the SVG path element

Good catch

@twschiller twschiller merged commit 62531c2 into main Mar 12, 2024
16 checks passed
@twschiller twschiller deleted the F/bugs/edge-crash-sidepanel branch March 12, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working edge MS Edge Chromium support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MS Edge MV3 crashes when clicking sidebar gear icon
2 participants