MS Edge: clicking a link in a sidebar mod crashes MS Edge

[twschiller]

Steps to Reproduce

• Click the "Open Google Sheet" link in the Announcements/Notices Mod Sidebar

Actual Behavior

• MS Edge crashes
• PixieBrix no longer installed (might only impact load unpacked?)

Discussion

• In previous PRs, we had fixed native link behavior: #7809: Fix Edge sidePanel links crash bug #7889. This might be a regression? An issue stemming from use of Shadow DOM if the handler can't intercept it?

Playwright Test Scenarios (can be put in a single test mod)

• Click the gear to open the Extension Console
• Use a test mod with the following: @pixies/test/sidebar-links
  • Open in tab brick
  • Link in markdown rendered in text element
  • Link in embedded HTML brick
  • Link in embedded form: form description and field description support markdown. Likely only need to test 1

[twschiller]

PR merged. Remaining work is to add playwright test for the scenarios. Assigning to myself for tests

[twschiller]

@fregante how was the PR tested? On https://github.com/pixiebrix/pixiebrix-extension/actions/runs/8638318978 the gear icon isn't doing anything for me. It doesn't change style on hover and isn't responding to clicks

I documented additional problems in the PR: #8216 (comment)

• The sidebar closes when you click a link (is that intended?)
• MS Edge crashes if you click a link in an iframe

[fregante]

Commented in your PR

[twschiller]

I've submitted a minimal reproduction to the MS Edge team: microsoft/MicrosoftEdge-Extensions#145

[twschiller]

@grahamlangford on Chrome I'm seeing that the browser automatically injects the content script. However, on MS Edge the content script is not injected

Chrome:

MS Edge:

I think we're going to have to raise with w3c extensions and MS Edge issue tracker that there's a discrepancy in which frames the content script is automatically injected into

In your research, are we even able to inject the content script into a frame within the sidebar in MS Edge?

[grahamlangford]

In your research, are we even able to inject the content script into a frame within the sidebar in MS Edge?

No, nothing I tried (adjusting permissions, setting to DEBUG, etc.) resulted in the content script getting injected

[twschiller]

@grahamlangford a fix is in the MS Edge canary build: microsoft/MicrosoftEdge-Extensions#145 (comment): https://learn.microsoft.com/en-us/deployedge/microsoft-edge-release-schedule