Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8206: Open sidePanel target="_blank" links in a new window to avoid closing sidebar #8224

Closed

Conversation

fregante
Copy link
Contributor

Note

Based on #8223, please merge that one first. This is a proposal

What does this PR do?

I don't know we can change how Edge deals with the sidebar (microsoft/MicrosoftEdge-Extensions#142), so this might be a solution:

  • open links in a brand new window/popup

This isn't ideal, but it's better than losing the sidebar I think.

Demo

Untested

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer: @fungairino

@fregante fregante added bug Something isn't working edge MS Edge Chromium support labels Apr 11, 2024
Copy link

It looks like one of the non-strict messenger/api.ts files ended up being imported by one of the strict files. Don't be fooled by "just a few type errors", this hides hundreds of type errors.

See details and solutions in: #6526 (comment)

There might be further information about how the non-strict Messenger files are ending up in the strict config:

 
src/background/messenger/api.t

  Imported via "@/background/messenger/api" from file 'src/utils/openAllLinksInPopups.ts'

@twschiller
Copy link
Contributor

@twschiller twschiller closed this Apr 13, 2024
@twschiller twschiller changed the title #8206: Handle target blank in sidePanel sub-frames #8206: Open sidePanel target="_blank" links in a new window to avoid closing sidebar Apr 13, 2024
@fregante fregante deleted the F/bug/open-links-in-window branch April 13, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working edge MS Edge Chromium support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants