Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#8127: adds test for activation url #8462

Merged
merged 6 commits into from
May 15, 2024
Merged

#8127: adds test for activation url #8462

merged 6 commits into from
May 15, 2024

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

Checklist

  • Add jest or playwright tests and/or storybook stories
  • Designate a primary reviewer @fungairino

@grahamlangford grahamlangford linked an issue May 14, 2024 that may be closed by this pull request
Add a Playwright test that confirms Extension Console activation via shared mod url #8127
Closed
@grahamlangford grahamlangford self-assigned this May 14, 2024
@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.40%. Comparing base (6d95047) to head (1c48d78).
Report is 66 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8462      +/-   ##
==========================================
- Coverage   73.47%   73.40%   -0.08%     
==========================================
  Files        1334     1352      +18     
  Lines       41259    41555     +296     
  Branches     7686     7799     +113     
==========================================
+ Hits        30316    30504     +188     
- Misses      10943    11051     +108

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

Playwright test results - MV2

passed  44 passed
skipped  12 skipped

Details

report  Open report ↗︎
stats  56 tests across 19 suites
duration  12 minutes, 11 seconds
commit  1c48d78

Skipped tests

chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
chrome › tests/extensionConsoleActivation.spec.ts › can activate a mod via url
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsoleActivation.spec.ts › can activate a mod via url
chrome › tests/regressions/sidebarLinks.spec.ts › #8206: clicking links from the sidebar doesn't crash browser
edge › tests/regressions/sidebarLinks.spec.ts › #8206: clicking links from the sidebar doesn't crash browser
chrome › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

Playwright test results - MV3

passed  56 passed

Details

report  Open report ↗︎
stats  56 tests across 19 suites
duration  16 minutes, 43 seconds
commit  1c48d78

@fungairino
Copy link
Collaborator

not related to this PR, but ugh, annoying to still see flaky mv3 tests pop up. We should try to fix these asap.

@github-actions GitHub Actions
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@grahamlangford grahamlangford enabled auto-merge (squash) May 15, 2024 12:53
@twschiller twschiller added this to the 2.0.0 milestone May 15, 2024
@grahamlangford
Merge branch 'main' of github.com:pixiebrix/pixiebrix-extension into …
5bd7e7f 
…8127-add-a-playwright-test-that-confirms-extension-console-activation-via-shared-mod-url
fungairino
fungairino reviewed May 15, 2024
View reviewed changes
end-to-end-tests/tests/extensionConsoleActivation.spec.ts
await expect(page).toHaveURL(
`chrome-extension://${extensionId}/options.html#/marketplace/activate/${modIdUrlEncoded}`,
);
}).toPass({ timeout: 5000 });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you could instead use the built-in waitForUrl : https://playwright.dev/docs/api/class-page#page-wait-for-url

@grahamlangford grahamlangford merged commit beef391 into main May 15, 2024
22 checks passed
@grahamlangford grahamlangford deleted the 8127-add-a-playwright-test-that-confirms-extension-console-activation-via-shared-mod-url branch May 15, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fungairino fungairino fungairino approved these changes

@mnholtz mnholtz Awaiting requested review from mnholtz

Assignees

@grahamlangford grahamlangford

Labels
testing
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Add a Playwright test that confirms Extension Console activation via shared mod url
3 participants
@grahamlangford @fungairino @twschiller