Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove standalone mod components - phase 4 - wip #8984

Closed
wants to merge 1 commit into from

Conversation

BLoe
Copy link
Contributor

@BLoe BLoe commented Aug 8, 2024

What does this PR do?

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

github-actions bot commented Aug 8, 2024

Playwright test results

failed  6 failed
passed  6 passed
skipped  116 skipped

Details

report  Open report ↗︎
stats  128 tests across 43 suites
duration  1 minute, 44 seconds
commit  000d8a6
info  For more information on how to debug and view this report, see our readme

Failed tests

chromeSetup › setup/affiliated.setup.ts › authenticate with affiliated user
edgeSetup › setup/affiliated.setup.ts › authenticate with affiliated user
chromeSetup › setup/affiliated.setup.ts › authenticate with affiliated user
edgeSetup › setup/affiliated.setup.ts › authenticate with affiliated user
chromeSetup › setup/affiliated.setup.ts › authenticate with affiliated user
edgeSetup › setup/affiliated.setup.ts › authenticate with affiliated user

Skipped tests

chrome › tests/bricks/sidebarEffects.spec.ts › sidebar effect bricks › toggle sidebar brick
edge › tests/bricks/sidebarEffects.spec.ts › sidebar effect bricks › toggle sidebar brick
chrome › tests/deployments/deploymentActivation.spec.ts › activate a deployed mod in the extension console
edge › tests/deployments/deploymentActivation.spec.ts › activate a deployed mod in the extension console
chrome › tests/extensionConsole/activation.spec.ts › can activate a mod with no config options
chrome › tests/extensionConsole/activation.spec.ts › can activate a mod with built-in integration
chrome › tests/extensionConsole/activation.spec.ts › can activate a mod with a database
chrome › tests/extensionConsole/activation.spec.ts › activating a mod when the quickbar shortcut is not configured
chrome › tests/extensionConsole/activation.spec.ts › can activate a mod via url
edge › tests/extensionConsole/activation.spec.ts › can activate a mod with no config options
edge › tests/extensionConsole/activation.spec.ts › can activate a mod with built-in integration
edge › tests/extensionConsole/activation.spec.ts › can activate a mod with a database
edge › tests/extensionConsole/activation.spec.ts › activating a mod when the quickbar shortcut is not configured
edge › tests/extensionConsole/activation.spec.ts › can activate a mod via url
chrome › tests/extensionConsole/modsPage.spec.ts › can open mod in the workshop
edge › tests/extensionConsole/modsPage.spec.ts › can open mod in the workshop
chrome › tests/extensionConsole/zapierModal.spec.ts › Zapier Integration Modal › can copy Zapier key and close modal
edge › tests/extensionConsole/zapierModal.spec.ts › Zapier Integration Modal › can copy Zapier key and close modal
chrome › tests/modLifecycle.spec.ts › create, run, package, and update mod
edge › tests/modLifecycle.spec.ts › create, run, package, and update mod
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add new starter brick
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
edge › tests/pageEditor/addStarterBrick.spec.ts › Add new starter brick
edge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
chrome › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior
edge › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior
chrome › tests/pageEditor/brickConfiguration.spec.ts › brick configuration
edge › tests/pageEditor/brickConfiguration.spec.ts › brick configuration
chrome › tests/pageEditor/copyMod.spec.ts › copying a mod that uses the PixieBrix API is copied correctly
chrome › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
edge › tests/pageEditor/copyMod.spec.ts › copying a mod that uses the PixieBrix API is copied correctly
edge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
chrome › tests/pageEditor/liveEditing.spec.ts › live editing behavior
edge › tests/pageEditor/liveEditing.spec.ts › live editing behavior
chrome › tests/pageEditor/logsPane.spec.ts › can view error logs
edge › tests/pageEditor/logsPane.spec.ts › can view error logs
chrome › tests/pageEditor/modEditorPane.spec.ts › mod editor pane behavior
edge › tests/pageEditor/modEditorPane.spec.ts › mod editor pane behavior
chrome › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod
edge › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod
chrome › tests/pageEditor/saveMod.spec.ts › shows error notification when updating a public mod without incrementing the version
edge › tests/pageEditor/saveMod.spec.ts › shows error notification when updating a public mod without incrementing the version
chrome › tests/pageEditor/specialPages.spec.ts › Restricted browser page
chrome › tests/pageEditor/specialPages.spec.ts › Unavailable mod
chrome › tests/pageEditor/specialPages.spec.ts › Page Editor reload
edge › tests/pageEditor/specialPages.spec.ts › Restricted browser page
edge › tests/pageEditor/specialPages.spec.ts › Unavailable mod
edge › tests/pageEditor/specialPages.spec.ts › Page Editor reload
chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
edge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/regressions/formFlicker.spec.ts › forms flickering due to components unexpectedly unmounting/remounting › #8320: Search field loses focus while typing on snippet mod
edge › tests/regressions/formFlicker.spec.ts › forms flickering due to components unexpectedly unmounting/remounting › #8320: Search field loses focus while typing on snippet mod
chrome › tests/regressions/hideModalsOnPageEditorRefresh.spec.ts › should hide add brick modal when Page Editor refreshes
edge › tests/regressions/hideModalsOnPageEditorRefresh.spec.ts › should hide add brick modal when Page Editor refreshes
chrome › tests/regressions/sandboxBrickErrors.spec.ts › #8821: ensure Javascript script errors are thrown during brick runtime
edge › tests/regressions/sandboxBrickErrors.spec.ts › #8821: ensure Javascript script errors are thrown during brick runtime
chrome › tests/regressions/sidebarLinks.spec.ts › #8206: clicking links from the sidebar doesn't crash browser
edge › tests/regressions/sidebarLinks.spec.ts › #8206: clicking links from the sidebar doesn't crash browser
chrome › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page
edge › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page
chrome › tests/runtime/allFrames.spec.ts › 8527: availability allFrames declaration
edge › tests/runtime/allFrames.spec.ts › 8527: availability allFrames declaration
chrome › tests/runtime/customEvents.spec.ts › custom event brick functionality
edge › tests/runtime/customEvents.spec.ts › custom event brick functionality
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
edge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
chrome › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8157: can insert at cursor from side bar
chrome › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu
edge › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8157: can insert at cursor from side bar
edge › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu
chrome › tests/runtime/localIntegrations.spec.ts › Local Integrations Page › can create a new integration
chrome › tests/runtime/localIntegrations.spec.ts › Local Integrations Page › #8067: blank numeric text integration configuration field validated on save
edge › tests/runtime/localIntegrations.spec.ts › Local Integrations Page › can create a new integration
edge › tests/runtime/localIntegrations.spec.ts › Local Integrations Page › #8067: blank numeric text integration configuration field validated on save
chrome › tests/runtime/setInputValue.spec.ts › can set input value
edge › tests/runtime/setInputValue.spec.ts › can set input value
chrome › tests/runtime/sidebar/sidebarActivation.spec.ts › initiates sidebar mod activation from activate url click
edge › tests/runtime/sidebar/sidebarActivation.spec.ts › initiates sidebar mod activation from activate url click
chrome › tests/runtime/sidebar/sidebarActivation.spec.ts › does not redirect to non-pixiebrix domain
edge › tests/runtime/sidebar/sidebarActivation.spec.ts › does not redirect to non-pixiebrix domain
chrome › tests/runtime/sidebar/sidebarAuth.spec.ts › Connect action in partner auth sidebar takes user to the Extension Console
edge › tests/runtime/sidebar/sidebarAuth.spec.ts › Connect action in partner auth sidebar takes user to the Extension Console
chrome › tests/runtime/sidebar/sidebarController.spec.ts › sidebar controller › can open sidebar immediately from iframe without focus dialog
chrome › tests/runtime/sidebar/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
chrome › tests/runtime/sidebar/sidebarController.spec.ts › sidebar controller › prevents host page styles from leaking into dialog
edge › tests/runtime/sidebar/sidebarController.spec.ts › sidebar controller › can open sidebar immediately from iframe without focus dialog
edge › tests/runtime/sidebar/sidebarController.spec.ts › sidebar controller › shows focus dialog in top-level frame
edge › tests/runtime/sidebar/sidebarController.spec.ts › sidebar controller › prevents host page styles from leaking into dialog
chrome › tests/runtime/sidebar/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
chrome › tests/runtime/sidebar/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
edge › tests/runtime/sidebar/sidebarNavigation.spec.ts › sidebar mod panels are persistent during navigation
edge › tests/runtime/sidebar/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
chrome › tests/runtime/sidebar/sidebarPanelTheme.spec.ts › custom sidebar theme css file is applied to all levels of sidebar document
edge › tests/runtime/sidebar/sidebarPanelTheme.spec.ts › custom sidebar theme css file is applied to all levels of sidebar document
chrome › tests/runtime/srcdocFrames.spec.ts › 8143: mods can run in srcdoc iframes
edge › tests/runtime/srcdocFrames.spec.ts › 8143: mods can run in srcdoc iframes
chrome › tests/runtime/textSnippets.spec.ts › text snippet shortcut functionality
edge › tests/runtime/textSnippets.spec.ts › text snippet shortcut functionality
chrome › tests/smoke/floatingActionButton.spec.ts › sidebar page smoke test › can toggle the sidebar from the floating action button and view the related mod's sidebar panel
chrome › tests/smoke/floatingActionButton.spec.ts › sidebar page smoke test › can hide the floating action button
edge › tests/smoke/floatingActionButton.spec.ts › sidebar page smoke test › can toggle the sidebar from the floating action button and view the related mod's sidebar panel
edge › tests/smoke/floatingActionButton.spec.ts › sidebar page smoke test › can hide the floating action button
chrome › tests/smoke/modsPage.spec.ts › extension console mods page smoke test › can view available mods
edge › tests/smoke/modsPage.spec.ts › extension console mods page smoke test › can view available mods
chrome › tests/smoke/pageEditor.spec.ts › page editor smoke test › can open the page editor and connect to an open tab
edge › tests/smoke/pageEditor.spec.ts › page editor smoke test › can open the page editor and connect to an open tab
chrome › tests/smoke/sidebar.spec.ts › sidebar page smoke test › can open the sidebar from selection menu action and view the related mod's sidebar panel
edge › tests/smoke/sidebar.spec.ts › sidebar page smoke test › can open the sidebar from selection menu action and view the related mod's sidebar panel
chrome › tests/smoke/workshopPage.spec.ts › extension console workshop smoke test › can navigate to workshop page without a username
edge › tests/smoke/workshopPage.spec.ts › extension console workshop smoke test › can navigate to workshop page without a username
chrome › tests/telemetry/errors.spec.ts › can report errors to telemetry service
chrome › tests/telemetry/errors.spec.ts › can report a service worker error to telemetry service
edge › tests/telemetry/errors.spec.ts › can report errors to telemetry service
edge › tests/telemetry/errors.spec.ts › can report a service worker error to telemetry service
chrome › tests/workshop/createMod.spec.ts › can create a new mod from a yaml definition and update it
edge › tests/workshop/createMod.spec.ts › can create a new mod from a yaml definition and update it

@fungairino
Copy link
Collaborator

fungairino commented Aug 8, 2024

The failing affiliated user tests seem to be happening because of a race condition - the background automatic deployment seems to be taking longer sometimes which makes the deployment modal pop up in the extension console.

These should probably pass on retry, but if they keep failing you can try bumping this timeout, or we might need to look into a better way of telling when the auto deploy has finished.

await page.waitForTimeout(3000);

@twschiller twschiller added this to the 2.1.0 milestone Aug 8, 2024
@BLoe
Copy link
Contributor Author

BLoe commented Aug 8, 2024

Closing this in favor of separate, smaller PRs

@BLoe BLoe closed this Aug 8, 2024
@twschiller twschiller deleted the feature/8979-migrate-components-to-mods branch November 14, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants