-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove standalone mod components - phase 4 - wip #8984
Conversation
Playwright test resultsDetails Open report ↗︎ Failed testschromeSetup › setup/affiliated.setup.ts › authenticate with affiliated user Skipped testschrome › tests/bricks/sidebarEffects.spec.ts › sidebar effect bricks › toggle sidebar brick |
The failing affiliated user tests seem to be happening because of a race condition - the background automatic deployment seems to be taking longer sometimes which makes the deployment modal pop up in the extension console. These should probably pass on retry, but if they keep failing you can try bumping this timeout, or we might need to look into a better way of telling when the auto deploy has finished.
|
Closing this in favor of separate, smaller PRs |
What does this PR do?
For more information on our expectations for the PR process, see the
code review principles doc