Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iframe-resizer from 4.4.5 to 5.3.0 #9116

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 8, 2024

Bumps iframe-resizer from 4.4.5 to 5.3.0.

Release notes

Sourced from iframe-resizer's releases.

v5.3.0

What's Changed

This release of iframe-resizer has focused on the final few areas where performance could be further improved, with the aim that, even with the most complex pages; size changes are detected, calculated and dispatched from the iframe in under 1ms. Setting the log: true option will now measure and display this time.

In tests with Google Chrome on an M1 Mac, the examples page of the iframe-resizer website average around 0.3ms. The logging has been left on if you would like to see the results on your own system.

Performance

Changed

React

Angular

Fixes

Huge thanks to @​bjornoss for his work on the new Angular Directive.

Full Changelog: davidjbradshaw/iframe-resizer@v5.2.6...v5.3.0

v5.2.6

What's Changed

Full Changelog: davidjbradshaw/iframe-resizer@v5.2.5...v5.2.6

v5.2.5

What's Changed

... (truncated)

Commits

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
iframe-resizer [>= 5.2.a, < 5.3]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [iframe-resizer](https://github.com/davidjbradshaw/iframe-resizer) from 4.4.5 to 5.3.0.
- [Release notes](https://github.com/davidjbradshaw/iframe-resizer/releases)
- [Changelog](https://github.com/davidjbradshaw/iframe-resizer/blob/master/CHANGELOG.md)
- [Commits](davidjbradshaw/iframe-resizer@v4.4.5...v5.3.0)

---
updated-dependencies:
- dependency-name: iframe-resizer
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74%. Comparing base (8318d74) to head (4ac2237).
Report is 265 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9116      +/-   ##
==========================================
+ Coverage   74.24%   74.74%   +0.49%     
==========================================
  Files        1332     1345      +13     
  Lines       40817    41669     +852     
  Branches     7634     7755     +121     
==========================================
+ Hits        30306    31145     +839     
- Misses      10511    10524      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 8, 2024

Playwright test results

failed  4 failed
passed  93 passed
flaky  30 flaky
skipped  5 skipped

Details

report  Open report ↗︎
stats  132 tests across 44 suites
duration  13 minutes, 60 seconds
commit  4ac2237
info  For more information on how to debug and view this report, see our readme

Failed tests

chrome › tests/extensionConsole/activation.spec.ts › can activate a mod via url
msedge › tests/extensionConsole/activation.spec.ts › can activate a mod via url
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod

Flaky tests

chrome-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
msedge-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
chrome-setup › setup/unaffiliated.setup.ts › authenticate with unaffiliated user
chrome › tests/extensionConsole/activation.spec.ts › can activate a mod with no config options
chrome › tests/extensionConsole/activation.spec.ts › can activate a mod with a database
msedge › tests/extensionConsole/activation.spec.ts › activating a mod when the quickbar shortcut is not configured
chrome › tests/modLifecycle.spec.ts › create, run, package, and update mod
msedge › tests/modLifecycle.spec.ts › create, run, package, and update mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add new starter brick
chrome › tests/pageEditor/brickActions.spec.ts › brick actions panel behavior
chrome › tests/pageEditor/saveMod.spec.ts › shows error notification when updating a public mod without incrementing the version
msedge › tests/pageEditor/saveMod.spec.ts › can save a standalone trigger mod
msedge › tests/pageEditor/specialPages.spec.ts › Restricted browser page
msedge › tests/pageEditor/specialPages.spec.ts › Unavailable mod
chrome › tests/regressions/sandboxBrickErrors.spec.ts › #8821: ensure Javascript script errors are thrown during brick runtime
chrome › tests/regressions/sidebarLinks.spec.ts › #8206: clicking links from the sidebar doesn't crash browser
msedge › tests/regressions/sidebarLinks.spec.ts › #8206: clicking links from the sidebar doesn't crash browser
chrome › tests/runtime/customEvents.spec.ts › custom event brick functionality
msedge › tests/runtime/customEvents.spec.ts › custom event brick functionality
msedge › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu
chrome › tests/runtime/screenshotTab.spec.ts › screenshot tab brick functionality
msedge › tests/runtime/screenshotTab.spec.ts › screenshot tab brick functionality
chrome › tests/runtime/sidebar/sidebarActivation.spec.ts › does not redirect to non-pixiebrix domain
chrome › tests/runtime/sidebar/sidebarController.spec.ts › sidebar controller › can open sidebar immediately from iframe without focus dialog
msedge › tests/runtime/sidebar/sidebarPanelTheme.spec.ts › custom sidebar theme css file is applied to all levels of sidebar document
chrome › tests/smoke/floatingActionButton.spec.ts › sidebar page smoke test › can hide the floating action button
msedge › tests/smoke/floatingActionButton.spec.ts › sidebar page smoke test › can toggle the sidebar from the floating action button and view the related mod's sidebar panel
msedge › tests/smoke/pageEditor.spec.ts › page editor smoke test › can open the page editor and connect to an open tab
chrome › tests/smoke/sidebar.spec.ts › sidebar page smoke test › can open the sidebar from selection menu action and view the related mod's sidebar panel
chrome › tests/workshop/createMod.spec.ts › can create a new mod from a yaml definition and update it

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
chrome › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu

@grahamlangford
Copy link
Collaborator

@dependabot ignore this dependency -- separate ticket to upgrade

@dependabot dependabot bot closed this Sep 9, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 9, 2024

OK, I won't notify you about iframe-resizer again, unless you re-open this PR.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/iframe-resizer-5.3.0 branch September 9, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant