Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9105: move state controller to content script #9120

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Sep 8, 2024

What does this PR do?

Discussion

  • Tests use the content script platform by default

Future Work

  • Make get/set async

For more information on our expectations for the PR process, see the
code review principles doc

Copy link

github-actions bot commented Sep 8, 2024

Playwright test results

passed  124 passed
flaky  2 flaky
skipped  6 skipped

Details

report  Open report ↗︎
stats  132 tests across 44 suites
duration  11 minutes, 23 seconds
commit  23e04ed
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
chrome › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu
msedge › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu

@twschiller twschiller added this to the 2.1.2 milestone Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.74%. Comparing base (8318d74) to head (23e04ed).
Report is 264 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9120      +/-   ##
==========================================
+ Coverage   74.24%   74.74%   +0.49%     
==========================================
  Files        1332     1345      +13     
  Lines       40817    41666     +849     
  Branches     7634     7755     +121     
==========================================
+ Hits        30306    31142     +836     
- Misses      10511    10524      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 9, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit 62198c2 into main Sep 9, 2024
23 checks passed
@twschiller twschiller deleted the feature/9105-platform-state branch September 9, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants