#9105: make getState and setState async

[twschiller]

What does this PR do?

• Part of [Spike] POC of mod variable syncing #9105
• FLUP to #9105: move state controller to content script #9120
• Makes the getState/setState methods async in anticipation of #9105: POC of mod variable sync #9106

Discussion

• The main consideration is that page state could be updated between get + set calls. So WithAsyncModVariable's logic needed to be rewritten to ensure a valid async state shape

For more information on our expectations for the PR process, see the
code review principles doc

[twschiller]

This brick had to be updated to handle interleaving calls to get/set. The request id is now set immediately, which better matches the RTK Query behavior for request id

[github-actions]

Playwright test results

 119 passed
 7 flaky
 6 skipped

Details

 Open report ↗︎
 132 tests across 44 suites
 10 minutes, 59 seconds
 f82e25a
 For more information on how to debug and view this report, see our readme

Flaky tests

chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/runtime/customEvents.spec.ts › custom event brick functionality
chrome › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8157: can insert at cursor from side bar
msedge › tests/smoke/floatingActionButton.spec.ts › sidebar page smoke test › can hide the floating action button
chrome › tests/smoke/pageEditor.spec.ts › page editor smoke test › can open the page editor and connect to an open tab
chrome › tests/telemetry/errors.spec.ts › can report errors to telemetry service

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
chrome › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu
msedge › tests/runtime/insertAtCursor.spec.ts › Insert at Cursor › 8154: can insert at cursor after opening sidebar from selection menu

[codecov]

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.73%. Comparing base (8318d74) to head (f82e25a).
Report is 268 commits behind head on main.

Files with missing lines	Patch %	Lines
src/contentScript/pipelineProtocol/runMapArgs.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9122      +/-   ##
==========================================
+ Coverage   74.24%   74.73%   +0.48%     
==========================================
  Files        1332     1345      +13     
  Lines       40817    41647     +830     
  Branches     7634     7756     +122     
==========================================
+ Hits        30306    31125     +819     
- Misses      10511    10522      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[grahamlangford]

I don't know what lead to the order change, but if we ever want to enforce order for object keys or react props (that one can be a bit more problematic), there are some lint rules for it:

• https://eslint.org/docs/latest/rules/sort-keys
• https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-sort-props.md
• https://eslint.org/docs/latest/rules/sort-imports

[twschiller]

Not a functional change - just improving information hierarchy on the order

[github-actions]

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.