Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement withIdbErrorHandling for telemetry database #9226

Merged

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

For more information on our expectations for the PR process, see the
code review principles doc

@grahamlangford grahamlangford self-assigned this Oct 3, 2024
@grahamlangford grahamlangford added this to the 2.1.3 milestone Oct 3, 2024
@twschiller twschiller added runtime enhancement New feature or request labels Oct 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.79%. Comparing base (8318d74) to head (5c58ecd).
Report is 331 commits behind head on main.

Files with missing lines Patch % Lines
src/background/telemetry.ts 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9226      +/-   ##
==========================================
+ Coverage   74.24%   74.79%   +0.54%     
==========================================
  Files        1332     1367      +35     
  Lines       40817    42179    +1362     
  Branches     7634     7889     +255     
==========================================
+ Hits        30306    31546    +1240     
- Misses      10511    10633     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grahamlangford grahamlangford enabled auto-merge (squash) October 3, 2024 16:17
@grahamlangford grahamlangford merged commit cf3b817 into main Oct 3, 2024
23 checks passed
@grahamlangford grahamlangford deleted the implement-with-idb-error-handling-in-telemetry branch October 3, 2024 16:27
Copy link

github-actions bot commented Oct 3, 2024

Playwright test results

passed  114 passed
flaky  20 flaky
skipped  4 skipped

Details

report  Open report ↗︎
stats  138 tests across 45 suites
duration  16 minutes, 27 seconds
commit  5c58ecd
info  For more information on how to debug and view this report, see our readme

Flaky tests

chrome-setup › setup/affiliated.setup.ts › authenticate with affiliated user
msedge-setup › setup/affiliated.setup.ts › authenticate with affiliated user
chrome-setup › setup/affiliated.setup.ts › authenticate with affiliated user
msedge-setup › setup/affiliated.setup.ts › authenticate with affiliated user
msedge › tests/deployments/deploymentActivation.spec.ts › activate a deployed mod in the extension console
chrome › tests/extensionConsole/activation.spec.ts › can activate a mod with built-in integration
chrome › tests/extensionConsole/activation.spec.ts › can activate a mod with a database
msedge › tests/extensionConsole/activation.spec.ts › can activate a mod via url
chrome › tests/modLifecycle.spec.ts › create, run, package, and update mod
msedge › tests/modLifecycle.spec.ts › create, run, package, and update mod
chrome › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
msedge › tests/pageEditor/addStarterBrick.spec.ts › Add starter brick to mod
chrome › tests/pageEditor/copyMod.spec.ts › copying a mod that uses the PixieBrix API is copied correctly
msedge › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration
msedge › tests/pageEditor/modEditorPane.spec.ts › mod editor pane behavior
msedge › tests/regressions/sandboxBrickErrors.spec.ts › #8821: ensure Javascript script errors are thrown during brick runtime
chrome › tests/regressions/sidebarLinks.spec.ts › #8206: clicking links from the sidebar doesn't crash browser
msedge › tests/regressions/welcomeStarterBricks.spec.ts › #8740: can view the starter mods on the pixiebrix.com/welcome page
chrome › tests/runtime/sidebar/sidebarNavigation.spec.ts › sidebar form and temporary panels are unavailable after navigation
msedge › tests/runtime/srcdocFrames.spec.ts › 8143: mods can run in srcdoc iframes

Skipped tests

chrome › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
msedge › tests/regressions/doNotCloseSidebarOnPageEditorSave.spec.ts › #8104: Do not automatically close the sidebar when saving in the Page Editor
chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants