Various vtorc backports into v14 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: convert join with database_instance to a left join and prevent fixes from running if the information from database_instance is unavailable * test: add tests to verify the fix works Co-authored-by: Manan Gupta <[email protected]> Signed-off-by: Max Englander <[email protected]>
maxenglander
force-pushed
the
v14-mysql57-hc-gh-13190
branch
from
d0feacc
to
e3a3236
Compare
…ary failures (vitessio#13190) * test: add a failing test Signed-off-by: Manan Gupta <[email protected]> * feat: fix the problem Signed-off-by: Manan Gupta <[email protected]> * feat: read vttablet records for instances that have no mysql port too Signed-off-by: Manan Gupta <[email protected]> * feat: refactor the code Signed-off-by: Manan Gupta <[email protected]> * feat: add tests for the newly introduced function Signed-off-by: Manan Gupta <[email protected]> * test: fix test expectations Signed-off-by: Manan Gupta <[email protected]> * feat: fix flakiness in tests Signed-off-by: Manan Gupta <[email protected]> * feat: fix comments Signed-off-by: Manan Gupta <[email protected]> --------- Co-authored-by: Manan Gupta <[email protected]> Signed-off-by: Max Englander <[email protected]>
maxenglander
force-pushed
the
v14-mysql57-hc-gh-13190
branch
from
e3a3236
to
21cbfdb
Compare
…is stopped (vitessio#10786) * feat: add failing vtorc test * feat: consider replication stopped if either thread is stopped Co-authored-by: Manan Gupta <[email protected]> Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Max Englander <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
|
I have pushed some changes. Mostly they are minor fixes and fixes to the tests. Otherwise, this is perfect! Thank you @maxenglander for doing this! I know it couldn't have been a pleasant experience cherry-picking these changes!! |
Signed-off-by: Manan Gupta <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
maxenglander
requested review from
deepthi,
shlomi-noach and
GuptaManan100
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VTOrc backports into v14.
Related Issue(s)
Backports parts of the following: