Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various vtorc backports into v14 #82

Merged
merged 10 commits into from
Jul 10, 2023
Merged

Various vtorc backports into v14 #82

merged 10 commits into from
Jul 10, 2023

Commits on Jul 2, 2023

  1. VTOrc running PRS when database_instance empty bug fix. (vitessio#12019) 

    * feat: convert join with database_instance to a left join and prevent fixes from running if the information from database_instance is unavailable
* test: add tests to verify the fix works

Co-authored-by: Manan Gupta <[email protected]>
Signed-off-by: Max Englander <[email protected]>
    @GuptaManan100 @maxenglander
    2 people authored and maxenglander committed Jul 2, 2023
    Configuration menu
    Copy the full SHA
    6512ed1 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Improve VTOrc failure detection to be able to better handle dead prim… 

    …ary failures (vitessio#13190)

* test: add a failing test

Signed-off-by: Manan Gupta <[email protected]>

* feat: fix the problem

Signed-off-by: Manan Gupta <[email protected]>

* feat: read vttablet records for instances that have no mysql port too

Signed-off-by: Manan Gupta <[email protected]>

* feat: refactor the code

Signed-off-by: Manan Gupta <[email protected]>

* feat: add tests for the newly introduced function

Signed-off-by: Manan Gupta <[email protected]>

* test: fix test expectations

Signed-off-by: Manan Gupta <[email protected]>

* feat: fix flakiness in tests

Signed-off-by: Manan Gupta <[email protected]>

* feat: fix comments

Signed-off-by: Manan Gupta <[email protected]>

---------

Co-authored-by: Manan Gupta <[email protected]>
Signed-off-by: Max Englander <[email protected]>
    @GuptaManan100 @maxenglander
    2 people authored and maxenglander committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    21cbfdb View commit details
    Browse the repository at this point in the history

  2. BugFix: VTOrc should repair replication if either replication thread … 

    …is stopped (vitessio#10786)

* feat: add failing vtorc test
* feat: consider replication stopped if either thread is stopped

Co-authored-by: Manan Gupta <[email protected]>
Signed-off-by: Max Englander <[email protected]>
    @GuptaManan100 @maxenglander
    2 people authored and maxenglander committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ca9c1cc View commit details
    Browse the repository at this point in the history

  3. disable --disable_active_reparents in some reparent tests 

    Signed-off-by: Max Englander <[email protected]>
    @maxenglander
    maxenglander committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    e99c25c View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. fix some remaining invalid usages of host,port 

    Signed-off-by: Max Englander <[email protected]>
    @maxenglander
    maxenglander committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f17711d View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. feat: minor fixes 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    d3db1c8 View commit details
    Browse the repository at this point in the history

  2. test: fix the data race 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    dbaa3a1 View commit details
    Browse the repository at this point in the history

  3. test: fix ers tests properly 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7baff29 View commit details
    Browse the repository at this point in the history

  4. feat: fix build issues 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c2117bd View commit details
    Browse the repository at this point in the history

  5. feat: fix typing mistake 

    Signed-off-by: Manan Gupta <[email protected]>
    @GuptaManan100
    GuptaManan100 committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    139b04f View commit details
    Browse the repository at this point in the history