Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Heltec V3 boards #954

Merged
merged 5 commits into from
Feb 28, 2023
Merged

Conversation

Baptou88
Copy link
Contributor

@Baptou88 Baptou88 commented Nov 3, 2022

the changes I made come from this repository

hope it can help other people

@valeros
Copy link
Member

valeros commented Dec 1, 2022

Hi @Baptou88 ! I don't see these board officially supported https://github.com/espressif/arduino-esp32/tree/master/variants, please add them in the framework in the first place.

@Baptou88
Copy link
Contributor Author

Hi @valeros
the Pr that I did on the Esp32 repository to add these new boards has just been validated

@smerkadidit
Copy link

Hi @Baptou88 ! I don't see these board officially supported https://github.com/espressif/arduino-esp32/tree/master/variants, please add them in the framework in the first place.

I do see them in the list now, what would the next steps be?

@rk29
Copy link

rk29 commented Feb 1, 2023

Is there anything blocking this from being merged?

@valeros
Copy link
Member

valeros commented Feb 3, 2023

The PR won't be added until espressif/arduino-esp32#7737 is resolved.

@platypii
Copy link

The issue espressif/arduino-esp32#7737 is resolved, and the fix has been released in framework-arduinoespressif32 version 2.0.7.

Can this PR be merged please?

@valeros valeros merged commit 4cef0e5 into platformio:develop Feb 28, 2023
@valeros
Copy link
Member

valeros commented Feb 28, 2023

Thanks, merged!

@Baptou88
Copy link
Contributor Author

Baptou88 commented Mar 4, 2023

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants