wip: Scala3 migration #728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeuTit
commented
Mar 15, 2023
build.sbt
Outdated
| ) | ||
| case Some((3, _)) => | ||
| Seq( | ||
| "com.typesafe.slick" %% "slick" % "3.4.0-SNAPSHOT", |
There was a problem hiding this comment.
This is using a locally published version of Slick with the Scala3 Pull Request. You can find it here: slick/slick#2187
PeuTit
commented
Mar 15, 2023
PeuTit
commented
Mar 15, 2023
| @@ -158,7 +158,7 @@ trait HasDatabaseConfig[P <: BasicProfile] { | |||
| @deprecated("Use `profile` instead of `driver`", "2.1") | |||
| protected final lazy val driver: P = dbConfig.profile // field is lazy to avoid early initializer problems. | |||
| /** The Slick database extracted from `dbConfig`. */ | |||
| protected final def db: P#Backend#Database = dbConfig.db | |||
There was a problem hiding this comment.
I understood that this is Path Dependent Types but I didn't find a way to make it work. Any insight here would be much appreciated!
|
Running |
- Compiling on Scala3 & Scala2.13 - Avoid code duplication and improve readability by moving library imports into `Dependencies.scala`. - Make Scala 2.13 default scala version. - Add scala3 to github action workflow
mkurz
reviewed
Apr 5, 2023
|
Slick 3.5.0-M4 is out for Scala 3 (and 2.12 and 2.13) |
|
Superseded by #751 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross compiling to 2.13 & 3.
Fixed some issues regarding syntax and library not supported in Scala3.