Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 #751

Merged
merged 4 commits into from
Jul 15, 2023
Merged

Scala 3 #751

merged 4 commits into from
Jul 15, 2023

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Jul 10, 2023

No description provided.

@xuwei-k xuwei-k force-pushed the scala-3-build branch 2 times, most recently from fa7065a to ffbd6b9 Compare July 10, 2023 06:43
@xuwei-k xuwei-k marked this pull request as ready for review July 10, 2023 06:55
@xuwei-k xuwei-k mentioned this pull request Jul 10, 2023
"3.5.0-M4"
} else {
"3.4.1"
}
Copy link
Member

@mkurz mkurz Jul 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why keep using 3.4.x for Scala 2.13? Is there a reason not to switch to 3.5?

@mkurz
Copy link
Member

mkurz commented Jul 15, 2023

@xuwei-k I rebased your PR, made it use the M4 even when on Scala 2.13. I guess you kept using 3.4.x because of binary incompatibility, however we can release a new version and increment it to 5.2.x.

@mkurz
Copy link
Member

mkurz commented Jul 15, 2023

Let me know if you want to change something (in another pr), I will merge meanwhile.

@mkurz mkurz merged commit 1c60a94 into playframework:main Jul 15, 2023
12 checks passed
@mkurz
Copy link
Member

mkurz commented Jul 15, 2023

Tagged as 5.2.0-M1, unblocks playframework/omnidoc#231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants