Fixes/workaround for upcoming (> v3.4.3) ggplot2 release #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
Oct 6, 2023
cpsievert
commented
Oct 6, 2023
…d versions; use it across the board)
|
The one remaining failure is due to the fact that the dev version of ggplot2 breaks GGally. I'm just going to ignore that for now since it seems ggplot2 should be fixing that on their end before a release |
zeehio
reviewed
Oct 21, 2023
There was a problem hiding this comment.
@cpsievert, it seems to me you are hitting jeroen/jsonlite#420 here, that was fixed on jsonlite 1.8.7. Maybe you want to update your jsonlite locally 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a draft for now -- starting a PR to get visual testing results back
TODO