Updates for recent changes to ggplot2 ggproto guide API #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
ggplot2-dev
branch
from
e396ede
to
e10663f
Compare
cpsievert
commented
Nov 10, 2023
cpsievert
commented
Nov 10, 2023
cpsievert
commented
Nov 10, 2023
cpsievert
changed the title
cpsievert
changed the title
cpsievert
added a commit
that referenced
this pull request
Jan 6, 2024
Issue was silently introduced by #2315, but didn't become an issue until tidyverse/ggplot2@851233f
cpsievert
added a commit
that referenced
this pull request
Jan 14, 2024
* Start v4.10.4 release candidate * Bugfix for guide logic added to accomodate new ggplot2 guide logic Issue was silently introduced by #2315, but didn't become an issue until tidyverse/ggplot2@851233f * Update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirrors changes in tidyverse/ggplot2#5483. Note that is a follow-up of sorts to #2262 and #2301 where this new guide logic first started introducing breaking changes (which hasn't yet been released to CRAN, so we won't bother with backwards-compat for the old API)