Add redrawReglTraces subroutine #3067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- which (re)-draw scattergl, scatterpolargl, splom traces as well as splom regl grid line in one go, always in the correct order - packaging these gl draw calls in one subroutine is especially useful for drag and selections, where buffers of targeted traces/scene are updated, but *all* traces need to be redraw following clearGlCanvases
... no need for this now that we have redrawReglTraces
- no longer need _module.styleOnSelect! - selections on overlaid subplots now work! - remove clearViewport (for now), we could bring it back again to optimize selections on disjoint subplots.
Merged
alexcjohnson
reviewed
Oct 2, 2018
alexcjohnson
reviewed
Oct 2, 2018
|
Beautiful cleanup @etpinard - dunno if you want someone better versed in the regl code to weigh in, but from my standpoint this is ready to 💃 ! |
This was referenced Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2562, to be merged into #3057 to addressed @alexcjohnson 's #3057 (comment)
In brief, this PR makes regl-based traces coexist better. All their "draw" calls are done in one single subroutine. This preserves ordering and makes it easier to redraw the canvas on drag and selections. For now on, regl-based traces (excluding
parcoords) only update their buffers during_module.plotand do not do any "drawing".cc @dy @archmoj @antoinerg